Skip to content

Conversation

@rodriquelca
Copy link
Contributor

@rodriquelca rodriquelca commented Nov 21, 2025

Solution

  • Selective Variable Submission in Screens was imprroved
image

How to Test

  • Create a screen
  • Add a submit button
  • Select submit button
  • Go to advanced
  • Enable Submit Information
  • Select the variables

Related Tickets & Packages

  • Link to any related FOUR tickets, PRDs, or packages

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

ci:screen-builder:feature/FOUR-27781
ci:package-files:feature/FOUR-27781
ci:package-webentry:bugfix/FOUR-28177
ci:deploy


Note

Updates submit() to accept optional data payload and adds focused Jest tests and config for submission filtering and task completion.

  • Tasks:
    • Update resources/js/tasks/edit.js submit(task, dataToSubmit = this.formData) to use dataToSubmit for collection updates and task completion (PUT tasks/:id).
  • Tests:
    • Add tests/js/SubmissionDataFilter.test.js covering variable filtering and system variable preservation.
    • Add tests/js/SubmitMethod.test.js validating submit() behavior, collection handling, error handling, and system variables.
  • Tooling (Jest):
    • Add script test-submission to run new tests.
    • Switch to testEnvironment: node with URL option; narrow testMatch to the two new tests; simplify transforms and ignore patterns; scope roots to tests/js/.

Written by Cursor Bugbot for commit b1ef6c2. This will update automatically on new commits. Configure here.

@vladyrichter
Copy link

QA server K8S was successfully deployed https://ci-b63c2975e4.engk8s.processmaker.net

rodriquelca and others added 2 commits November 27, 2025 16:13
FOUR-28125: Submit information (enable/disable) does not have the sam…
@cursor
Copy link

cursor bot commented Nov 28, 2025

You have run out of free Bugbot PR reviews for this billing cycle. This will reset on December 21.

To receive reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.

@vladyrichter
Copy link

QA server K8S was successfully deployed https://ci-b63c2975e4.engk8s.processmaker.net

2 similar comments
@vladyrichter
Copy link

QA server K8S was successfully deployed https://ci-b63c2975e4.engk8s.processmaker.net

@vladyrichter
Copy link

QA server K8S was successfully deployed https://ci-b63c2975e4.engk8s.processmaker.net

@processmaker-sonarqube
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants