fix(Bouncer): Players bypass region protection and build permissions when using Quick Stack

Author: ACaiCat

TShockAPI/Bouncer.cs

@@ -137,6 +137,7 @@ internal Bouncer()
 			GetDataHandlers.KillMe += OnKillMe;
 			GetDataHandlers.FishOutNPC += OnFishOutNPC;
 			GetDataHandlers.FoodPlatterTryPlacing += OnFoodPlatterTryPlacing;
+			GetDataHandlers.ForceItemIntoNearestChest += OnForceItemIntoNearestChest;
 
 
 			// The following section is based off Player.PlaceThing_Tiles_PlaceIt and Player.PlaceThing_Tiles_PlaceIt_GetLegacyTileStyle.
@@ -2505,7 +2506,7 @@ internal void OnPlaceItemFrame(object sender, GetDataHandlers.PlaceItemFrameEven
 				Main.item[num].playerIndexTheItemIsReservedFor = args.Player.Index;
 				NetMessage.SendData((int)PacketTypes.ItemDrop, args.Player.Index, -1, NetworkText.Empty, num, 1f);
 				NetMessage.SendData((int)PacketTypes.ItemOwner, args.Player.Index, -1, NetworkText.Empty, num);
-				
+
 				TShock.Log.ConsoleDebug(GetString("Bouncer / OnPlaceItemFrame rejected permissions from {0}", args.Player.Name));
 				NetMessage.SendData((int)PacketTypes.UpdateTileEntity, -1, -1, NetworkText.Empty, args.ItemFrame.ID, 0, 1);
 				args.Handled = true;
@@ -2871,6 +2872,44 @@ internal void OnFoodPlatterTryPlacing(object sender, GetDataHandlers.FoodPlatter
 			}
 		}
 
+		/// <summary>
+		/// Called when a player is trying to put an item into chest through Quick Stack.
+		/// </summary>
+		/// <param name="sender"></param>
+		/// <param name="args"></param>
+		internal void OnForceItemIntoNearestChest(object sender, ForceItemIntoNearestChestEventArgs args)
+		{
+			var slot = args.Slot;
+
+			var id = Utils.LocateQuickStackChestIndex(args.Player, slot);
+
+			if (id == -1)
+				return;
+
+			if (args.Player.IsBeingDisabled())
+			{
+				TShock.Log.ConsoleDebug(GetString("Bouncer / OnForceItemIntoNearestChest rejected from disable from {0}", args.Player.Name));
+				args.Player.SendData(PacketTypes.PlayerSlot, "", args.Player.Index, slot, args.Player.TPlayer.inventory[slot].prefix);
+				args.Handled = true;
+				return;
+			}
+
+			if (!args.Player.HasBuildPermission(Main.chest[id].x, Main.chest[id].y) && TShock.Config.Settings.RegionProtectChests)
+			{
+				TShock.Log.ConsoleDebug(GetString("Bouncer / OnForceItemIntoNearestChest rejected from region protection? from {0}", args.Player.Name));
+				args.Player.SendData(PacketTypes.PlayerSlot, "", args.Player.Index, slot, args.Player.TPlayer.inventory[slot].prefix);
+				args.Handled = true;
+				return;
+			}
+
+			if (!args.Player.IsInRange(Main.chest[id].x, Main.chest[id].y))
+			{
+				TShock.Log.ConsoleDebug(GetString("Bouncer / OnForceItemIntoNearestChest rejected from range check from {0}", args.Player.Name));
+				args.Handled = true;
+				return;
+			}
+		}
+
 		internal void OnSecondUpdate()
 		{
 			Task.Run(() =>

TShockAPI/Utils.cs

@@ -1202,5 +1202,77 @@ internal void ComputeMaxStyles()
 				}
 			}
 		}
+
+		/// <summary>
+		/// Locates the nearest available chest suitable for quick-stacking items from the player's inventory.
+		/// </summary>
+		/// <param name="player">The player attempting to quick-stack items.</param>
+		/// <param name="slot">The inventory slot of the item being quick-stacked (currently unused in this method).</param>
+		/// <returns>
+		/// The index of the nearest available chest within range that isn't locked or in use, or -1 if no suitable chest is found.
+		/// </returns>
+		public static int LocateQuickStackChestIndex(TSPlayer player, short slot)
+		{
+		    const float maxDistance = 600f;
+		    Item item;
+
+		    if (slot >= PlayerItemSlotID.Bank4_0 && slot < PlayerItemSlotID.Bank4_0 + NetItem.VoidSlots)
+		    {
+			    var index = slot - PlayerItemSlotID.Bank4_0;
+			    item = player.TPlayer.bank4.item[index];
+		    }
+		    else
+		    {
+			    if (slot >= NetItem.InventorySlots - 1)
+				    return -1;
+			    item = player.TPlayer.inventory[slot];
+		    }
+
+		    for (var i = 0; i < Main.maxChests; i++)
+		    {
+			    var chest = Main.chest[i];
+			    if (chest == null || Chest.IsPlayerInChest(i) || Chest.IsLocked(chest.x, chest.y))
+				    continue;
+
+			    var chestPos = new Vector2(chest.x * 16 + 16, chest.y * 16 + 16);
+			    if ((chestPos - player.TPlayer.position).Length() >= maxDistance)
+				    continue;
+
+			    var canStack = false;
+			    var hasSpace = false;
+
+			    foreach (var chestItem in chest.item)
+			    {
+				    if (chestItem.IsAir)
+				    {
+					    hasSpace = true;
+					    continue;
+				    }
+
+				    if (item.IsTheSameAs(chestItem))
+				    {
+					    canStack = true;
+					    var space = chestItem.maxStack - chestItem.stack;
+					    if (space > 0)
+					    {
+						    return i;
+					    }
+				    }
+				    else
+				    {
+					    hasSpace = true;
+				    }
+			    }
+
+			    if (canStack && hasSpace && item.stack > 0)
+			    {
+				    if (chest.item.Any(t => t.IsAir))
+				    {
+					    return i;
+				    }
+			    }
+		    }
+		    return -1;
+		}
 	}
 }