Skip to content

Conversation

@ACaiCat
Copy link
Contributor

@ACaiCat ACaiCat commented Jun 15, 2025

Fixed players bypass region protection and build permissions when using Quick Stack

Problem

  • Players who aren't logged in can use Quick Stack to put items into chests.
  • Many players report stacking items into protected regions when using Quick Stack.
    image

@ACaiCat ACaiCat marked this pull request as draft June 15, 2025 16:01
@ACaiCat ACaiCat marked this pull request as ready for review June 15, 2025 16:07
@ACaiCat ACaiCat marked this pull request as draft June 15, 2025 16:37
@ACaiCat ACaiCat marked this pull request as ready for review June 15, 2025 16:47
@ACaiCat ACaiCat force-pushed the general-devel branch 3 times, most recently from c912260 to 953bff1 Compare June 16, 2025 00:57
@pull-request-size pull-request-size bot added size/M and removed size/L labels Jun 16, 2025
Copy link
Member

@hakusaro hakusaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like you setup a new TShock event for ForceItemIntoNearestChest in 939d158 but then in 6c500df you don't ever fire the event?

Copy link
Member

@bartico6 bartico6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Undecided, would like feedback from PR author and other maintainers about the comment I left in bouncer code

@sgkoishi
Copy link
Member

It looks like you setup a new TShock event for ForceItemIntoNearestChest in 939d158 but then in 6c500df you don't ever fire the event?

The ForceItemIntoNearestChestEventArgs was added to the handler list so should be fired whenever PacketTypes.ForceItemIntoNearestChest received...?

Would be better if we could move items to other accessible chests

… and rename method

Players are not able to quick-stack items into out-of-range chests.
@hakusaro
Copy link
Member

The ForceItemIntoNearestChestEventArgs was added to the handler list so should be fired whenever PacketTypes.ForceItemIntoNearestChest received...?

I am awake

@ACaiCat ACaiCat requested a review from hakusaro June 26, 2025 11:01
@ACaiCat ACaiCat changed the title fix(Bouncer): Players bypass region protection and build permissions when using Quick Stack fix(Bouncer): fix players bypass region protection and build permissions when using Quick Stack Jul 6, 2025
@ACaiCat ACaiCat closed this Jul 25, 2025
@ACaiCat ACaiCat reopened this Sep 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants