Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How can the Tutorials chair get access to accept and reject tutorials? #604

Open
brandon-rhodes opened this issue Jul 19, 2016 · 3 comments
Assignees

Comments

@brandon-rhodes
Copy link
Contributor

brandon-rhodes commented Jul 19, 2016

  • How do permissions wind up getting created in the permissions table?
  • What do the first and last part of a dotted permission name like reviews.can_manage_tutorials refer to in the Django database?
  • Why could we not find a permission that we could grant the Tutorials chair that would make the view review_section() in symposion/reviews/views.py show the accept / reject dropdown choices when the chair viewed the URL https://us.pycon.org/2016/reviews/section/tutorials/?

We need documentation for:

  • Exactly the permission that will give a Tutorials Chair the ability to visit https://us.pycon.org/2016/reviews/section/tutorials/ and see the accept / reject buttons.
  • Exactly the permission that will let the Tutorials Chair visit https://us.pycon.org/2016/reviews/section/tutorials/ and see the "Result Notification" link over in the red-and-pink navigation bar that already says "Reviews" and "Voting status".
  • Exactly the permission that will let the Tutorials Chair visit https://us.pycon.org/2016/reviews/section/tutorials/notification/accepted/ and see the accepted and rejected tutorials that are eligible to be emailed.

The problem could be a spelling error in the permissions checks in views.py, or the problem could be that the permissions are not being correctly created in the first place, or the problem could be stale data in a fixture that was not updated when the code was updated.

@dpoirier
Copy link
Contributor

Note that the intention of the original authors was not to have to assign specific Django permissions in the admin. There's some functionality in the dashboard to make people reviewers for various types of proposals. There might be Django groups defined for various roles as well. Or it could well be a bug; this part of the code only gets exercised once a year.

@wtheisen
Copy link

wtheisen commented Jul 24, 2016

The reason that the Tutorials chair cannot see the "Result Notification" link is due to a check made to see if the user is "staff" in symposion/templates/reviews/base.html and not whether or not they have the permissions to manage the particular section.

@dpoirier
Copy link
Contributor

Definitely a bug then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants