Cleanup websocket streaming code #2143
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kt474
changed the title
kt474
commented
Feb 19, 2025
| remedy="This option will have no effect since interim " | ||
| "results streaming was removed in a previous release.", | ||
| stacklevel=3, | ||
| ) |
There was a problem hiding this comment.
My understanding is that even though this option doesn't do anything, we still need to properly deprecate before removing.
kt474
commented
Feb 19, 2025
| "These parameters will be removed in a future release.", | ||
| category=FutureWarning, | ||
| stacklevel=2, | ||
| ) |
There was a problem hiding this comment.
Same here - user_callback and client_params don't do anything in the job classes but following the deprecation policy I don't think we can just remove them?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Details and comments
Fixes #2140