You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
In qmi.core.config_defs configstruct CfgContext it is possible to define virtualenv_path value. This is meant to point to the location of the possible virtual Python environment to be used in the context. Currently it is used in QMI only in qmi.tools.prochere. But the implementation is
a) obsoleted as new 'venvs' do not usually set separately 'python3' anymore, but simply 'python';
b) the subdir 'bin' is used in Unix-like environments only. In Windows, it is 'Scripts'. Probably need to define it with '.exe' as well.
When running this on more recent Python and venv versions, or on a Windows PC, this will fail.
To Reproduce
Make a script to run a QMI context where the script module and 'virtualenv_path' are defined in qmi.conf (or other QMI configuration file). Run the script with qmi_proc or modern Python on Unix and Windows PC.
Expected behavior
The script will fail when trying to do os.path.join(venv_path, "bin", "python3") on L287 of qmi_proc.py.
Operating System (please complete the following information):
OS: Linux, Windows
Additional context
Python: 3.11 or newer
virtual environment must be present or be created (and destroyed) when running the test script.
The text was updated successfully, but these errors were encountered:
Describe the bug
In
qmi.core.config_defs
configstructCfgContext
it is possible to definevirtualenv_path
value. This is meant to point to the location of the possible virtual Python environment to be used in the context. Currently it is used in QMI only inqmi.tools.proc
here. But the implementation isa) obsoleted as new 'venvs' do not usually set separately 'python3' anymore, but simply 'python';
b) the subdir 'bin' is used in Unix-like environments only. In Windows, it is 'Scripts'. Probably need to define it with '.exe' as well.
When running this on more recent Python and venv versions, or on a Windows PC, this will fail.
To Reproduce
Make a script to run a QMI context where the script module and 'virtualenv_path' are defined in
qmi.conf
(or other QMI configuration file). Run the script withqmi_proc
or modern Python on Unix and Windows PC.Expected behavior
The script will fail when trying to do
os.path.join(venv_path, "bin", "python3")
on L287 ofqmi_proc.py
.Operating System (please complete the following information):
Additional context
The text was updated successfully, but these errors were encountered: