Skip to content

Commit 7a12bc6

Browse files
fix: Only warn about nullability on non-primary-key columns (#89)
1 parent 727cc55 commit 7a12bc6

File tree

1 file changed

+7
-3
lines changed

1 file changed

+7
-3
lines changed

dataframely/columns/_base.py

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -75,12 +75,16 @@ def __init__(
7575

7676
if nullable and primary_key:
7777
warn_no_nullable_primary_keys()
78+
nullable = False
7879

7980
if nullable is None:
80-
warn_nullable_default_change()
81-
nullable = True
81+
if primary_key:
82+
nullable = False
83+
else:
84+
warn_nullable_default_change()
85+
nullable = True
8286

83-
self.nullable = nullable and not primary_key
87+
self.nullable = nullable
8488
self.primary_key = primary_key
8589
self.check = check
8690
self.alias = alias

0 commit comments

Comments
 (0)