Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[✨] Allow for multiple keyed menus with useContent #101

Closed
watzon opened this issue Jan 5, 2023 · 1 comment
Closed

[✨] Allow for multiple keyed menus with useContent #101

watzon opened this issue Jan 5, 2023 · 1 comment
Labels
[STAGE-2] incomplete implementation Remove this label when implementation is complete [STAGE-2] not fully covered by tests yet Remove this label when tests are verified to cover the implementation [STAGE-2] unresolved discussions left Remove this label when all critical discussions are resolved on the issue [STAGE-3] docs changes not added yet Remove this label when the necessary documentation for the feature / change is added [STAGE-3] missing 2 reviews for RFC PRs Remove this label when at least 2 core team members reviewed and approved the RFC implementation

Comments

@watzon
Copy link

watzon commented Jan 5, 2023

Is your feature request related to a problem?

Currently it seems like it's only possible to define a single menu inside of menu.md. This makes it frustrating to account for the possibility of multiple menus, such as a header menu and a footer menu (which will probably contain a basic sitemap).

Describe the solution you'd like

There are a couple good ways I can think of handling this. Keep in mind that I have done zero digging into the code to see how things are structured, so take these with a grain of salt.

  1. Allow for multiple menus to be defined in menu.md using top level headings. For example:
    # Header
    
    ## [Home](/)
    
    ## [About](/about)
    
    # Footer
    
    <!-- Other footer specific menu items -->
  2. Allow for multiple menu.md files the same way we allow for multiple layouts, and allow useContent to accept an identifier as a parameter. So useContent() would use menu.md, while useContent('footer') would use menu-footer.md.

Describe alternatives you've considered

The obvious one is to just hard code the menu into the component, use a json file, or use an exported javascript object from another file. This is how I will probably handle the problem for now, but I wanted to bring this idea up for discussion anyway.

Additional context

No response

@gioboa
Copy link
Member

gioboa commented Oct 14, 2024

We moved this issue to qwik-evolution repo to create a RFC discussion for this.
Here is our Qwik RFC process thanks.

@gioboa gioboa transferred this issue from QwikDev/qwik Oct 14, 2024
@github-project-automation github-project-automation bot moved this to In Progress (STAGE 2) in Qwik Evolution Oct 14, 2024
@github-actions github-actions bot added [STAGE-2] incomplete implementation Remove this label when implementation is complete [STAGE-2] not fully covered by tests yet Remove this label when tests are verified to cover the implementation [STAGE-2] unresolved discussions left Remove this label when all critical discussions are resolved on the issue [STAGE-3] docs changes not added yet Remove this label when the necessary documentation for the feature / change is added [STAGE-3] missing 2 reviews for RFC PRs Remove this label when at least 2 core team members reviewed and approved the RFC implementation labels Oct 14, 2024
@QwikDev QwikDev locked and limited conversation to collaborators Oct 14, 2024
@gioboa gioboa converted this issue into discussion #177 Oct 14, 2024
@github-project-automation github-project-automation bot moved this from In Progress (STAGE 2) to Released as Stable (STAGE 5) in Qwik Evolution Oct 14, 2024
@shairez shairez removed this from Qwik Evolution Oct 15, 2024

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
[STAGE-2] incomplete implementation Remove this label when implementation is complete [STAGE-2] not fully covered by tests yet Remove this label when tests are verified to cover the implementation [STAGE-2] unresolved discussions left Remove this label when all critical discussions are resolved on the issue [STAGE-3] docs changes not added yet Remove this label when the necessary documentation for the feature / change is added [STAGE-3] missing 2 reviews for RFC PRs Remove this label when at least 2 core team members reviewed and approved the RFC implementation
Projects
None yet
Development

No branches or pull requests

2 participants