Column Type Change - Data Disappear

[yurijserrano]

Describe the bug
When I change the column type the data disappears

To Reproduce
Just change the type of the column and the data will disappear

Expected behavior
The data not disappear.

Video

2022-08-17.11-02-16.mp4

Desktop (please complete the following information):

• OS: Pop OS
• Version: 22.04

[RafaelGB]

when parsing a text type column to date, since they are not compatible with each other, a date is not shown, but the data remains intact in the files until it is modified

[yurijserrano]

Hi Rafael

Correct I could verify that

However I saw that the data is populated correctly when I exit the file and come back again, so I thought that this update can be done when the column type conversion is done.

This way I think the workflow would be better.

An example of this can be seen in the video below:

2022-08-17.11-20-22.mp4

[RafaelGB]

I will check if this function is working correctly

private parseToCalendar(wrapped: WrappedLiteral): DateTime {
        if (DateTime.isDateTime(wrapped.value)) {
            if (wrapped.type === 'string') {

                return DateTime.fromISO(wrapped.value);
            } else {
                return wrapped.value;
            }
        } else {
            return null;
        }
    }

[RafaelGB]

An improved parser:

private parseToCalendar(wrapped: WrappedLiteral): DateTime {
        if (wrapped.type === 'string') {
            const calendarCandidate = DateTime.fromISO(wrapped.value);
            if (calendarCandidate.isValid) {
                return calendarCandidate;
            }
            return null;
        }

        if (DateTime.isDateTime(wrapped.value)) {
            return wrapped.value;
        } else {
            return null;
        }
    }

Screen.Recording.2022-08-17.at.16.52.52.mov

[yurijserrano]

@RafaelGB Perfect this ends up fixing the problem of the data disappearing.

Do you intend to include this modification in the next version of the DB Folder?

[RafaelGB]

yeah Its already included on the main branch. will be added this week with a minor version

[yurijserrano]

Thank you so much @RafaelGB for your attention and fix to this matter

I wish you a great day

[RafaelGB]

included with 2.2.1

[yurijserrano]

Thank you so much @RafaelGB

I will be checking this new update later.

I wish you a great day.