Client versioning in API

kaplun · kaplun · commit 089af8d309cf · 2020-12-04T15:06:13.000+01:00
* Properly declares the client versioning when contacting the Proton
  API.

* Improves kwalitee.

Signed-off-by: Samuele Kaplun &lt;kaplun@protonmail.com&gt;
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,6 +2,7 @@
 
 ## Table of Contents
 
+- [v2.2.6](#v226)
 - [v2.2.5](#v225)
 - [v2.2.4](#v224)
 - [v2.2.3](#v223)
@@ -14,6 +15,10 @@
 - [v2.0.0](#v200)
 - [v0.1.0](#v010)
 
+## v2.2.6
+
+- Enhancement: Properly specifies versioning when contacting Proton API
+
 ## v2.2.5
 
 - Enhancement: Introduces support for the client to declare itself
diff --git a/protonvpn_cli/connection.py b/protonvpn_cli/connection.py
@@ -23,7 +23,7 @@
 )
 # Constants
 from .constants import (
-    CONFIG_DIR, OVPN_FILE, PASSFILE, CONFIG_FILE, CLIENT_SUFFIX
+    CONFIG_DIR, OVPN_FILE, PASSFILE, CONFIG_FILE
 )
 
 
diff --git a/protonvpn_cli/constants.py b/protonvpn_cli/constants.py
@@ -17,5 +17,5 @@
 SPLIT_TUNNEL_FILE = os.path.join(CONFIG_DIR, "split_tunnel.txt")
 OVPN_FILE = os.path.join(CONFIG_DIR, "connect.ovpn")
 PASSFILE = os.path.join(CONFIG_DIR, "pvpnpass")
-CLIENT_SUFFIX = "plc" # ProtonVPN Linux Community
-VERSION = "2.2.5"
+CLIENT_SUFFIX = "plc"  # ProtonVPN Linux Community
+VERSION = "2.2.6"
diff --git a/protonvpn_cli/utils.py b/protonvpn_cli/utils.py
@@ -28,7 +28,7 @@ def call_api(endpoint, json_format=True, handle_errors=True):
     url = api_domain + endpoint
 
     headers = {
-        "x-pm-appversion": "Other",
+        "x-pm-appversion": "LinuxVPN_{0}".format(VERSION),
         "x-pm-apiversion": "3",
         "Accept": "application/vnd.protonmail.v1+json"
     }

Original file line number	Diff line number	Diff line change
`@@ -23,7 +23,7 @@`
`23`	`23`	`)`
`24`	`24`	`# Constants`
`25`	`25`	`from .constants import (`
`26`		`- CONFIG_DIR, OVPN_FILE, PASSFILE, CONFIG_FILE, CLIENT_SUFFIX`
	`26`	`+ CONFIG_DIR, OVPN_FILE, PASSFILE, CONFIG_FILE`
`27`	`27`	`)`
`28`	`28`
`29`	`29`
Original file line number	Diff line number	Diff line change
`@@ -28,7 +28,7 @@ def call_api(endpoint, json_format=True, handle_errors=True):`
`28`	`28`	`url = api_domain + endpoint`
`29`	`29`
`30`	`30`	`headers = {`
`31`		`- "x-pm-appversion": "Other",`
	`31`	`+ "x-pm-appversion": "LinuxVPN_{0}".format(VERSION),`
`32`	`32`	`"x-pm-apiversion": "3",`
`33`	`33`	`"Accept": "application/vnd.protonmail.v1+json"`
`34`	`34`	`}`