Remove external CDN assets

[bensheldon]

I really like the polish on this gem and dashboard.

I noticed that there is an external asset referenced in the layout:

fuik/app/views/layouts/fuik/application.html.erb

Line 11 in d97f0e6

<script defer src="https://cdn.jsdelivr.net/npm/attractivejs@0.12.0"></script>

It would be great, for security/privacy, for all assets to be served by the gem directly.

My GoodJob has a way more complex dashboard (a burden not a brag) but maybe it’s helpful context for how you might serve this gem’s assets:

https://github.com/bensheldon/good_job/blob/main/app/controllers/good_job/frontends_controller.rb

[eelcoj]

Good call @bensheldon. Agreed. Should be able to pull/wget Attractve.js' umd version and use that directly. That is the simplest.

What is the reason for your controller set up? Incompatible assets? Legacy browser support?

[bensheldon]

What is the reason for your controller set up? Incompatible assets? Legacy browser support?

Several reasons, almost none of them deeply committed to:

• I’m very committed to the idea that gem engines are “no build” so they’re easy to fork and run off a git reference.
• I had enough complex JavaScript that I wanted to do modules, thus importmaps, and I needed a place to hang that configuration. I’m also paranoid about directory traversal (and relatively ignorant of Ruby’s filesystem interface), so I hardcoded everything.
• Anything put in app/assets seems to get picked up by the parent app’s sprockets, and I didn’t want anything to do with the asset pipeline in my gem to avoid that can of worms. Maybe I’m just missing an engine config somewhere instead.
• i wanted to put this all behind the same auth layer as everything else, which is controller driven.

I do wish I had better caching / cache busting in this, particularly when running the gem from a git reference.