Skip to content

Commit b486b6f

Browse files
committed
Bugfix: Create out_dir/tmp in parsebam if needed
Temp files from PyCoverM are stored in out_dir/tmp/pycoverm, but the tmp directory was not created by the parsebam module. This led to a failure to make the pycoverm dir, crashing Vamb. Fix issue #167
1 parent efa3e5a commit b486b6f

File tree

3 files changed

+5
-2
lines changed

3 files changed

+5
-2
lines changed

CHANGELOG.md

+3
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,8 @@
11
# Changelog
22

3+
## v4.1.1
4+
* Create tmp directory in parsebam if needed for pycoverm (issue # 167)
5+
36
## v4.1.0
47
* Fix typo in output AAE_Z cluster names. They are now called e.g. "aae_z_1"
58
instead of "aae_z1"

vamb/__init__.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
7) Split bins using vamb.vambtools
2020
"""
2121

22-
__version__ = (4, 1, 0)
22+
__version__ = (4, 1, 1)
2323

2424
from . import vambtools
2525
from . import parsebam

vamb/parsebam.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -164,7 +164,7 @@ def chunkwise_loading(
164164
target_refhash: Optional[bytes],
165165
mask: _np.ndarray,
166166
) -> A:
167-
_os.mkdir(cache_directory)
167+
_os.makedirs(cache_directory)
168168

169169
chunks = [
170170
(i, min(len(paths), i + nthreads)) for i in range(0, len(paths), nthreads)

0 commit comments

Comments
 (0)