Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] CSV imported 0 records #234

Open
sreich opened this issue Oct 5, 2024 · 4 comments
Open

[Bug] CSV imported 0 records #234

sreich opened this issue Oct 5, 2024 · 4 comments

Comments

@sreich
Copy link

sreich commented Oct 5, 2024

I'm wondering what's going on here, this is probably user error..., hard to say as the output/error it gives me is not very useful, it just says the import imported 0 records...The help gave a basic structure explanation...I think it would have been better to also just show a 2 line excerpt of the expected file it should import

Anyway...is it possible the other fields are necessary and it's throwing off the importer by now having them? I haven't dug into the code yet, just wanted a high level look first...maybe and the help text needs updated to mention this, because the expected format changed? Or what am I doing wrong...

"Activity","Start Time","End Time","Comment"
"Piano","2023-12-03 12:43:33","2023-12-03 17:58:19",""
"Piano","2023-12-03 13:18:03","2023-12-03 13:42:08",""
@Razeeman
Copy link
Owner

Razeeman commented Oct 5, 2024

Hello! Csv import is not very convenient at the moment or well documented. Can you please try same lines but with times without quotes. Like this

"Piano",2023-12-03 12:43:33,2023-12-03 17:58:19,""

@sreich
Copy link
Author

sreich commented Oct 8, 2024

excellent, that worked great. Thanks! This issue is resolved now, unless you wanted to use it as a marker to document or improve the importer

@Razeeman
Copy link
Owner

Glad it worked. Problem is that I'm not sure how to make it more convenient :)

@sreich
Copy link
Author

sreich commented Oct 30, 2024

Documenting the expected format on the page where you import is what I would start with as a first step

Next step could be to remove the quote confusion on columns. Seems like apps exporting are going to be quoting their fields. Although I'm not sure how many do it one way or another, but I would expect the app to understand that if it is both ways. Pass 2 is sanity checking against what we expect and tell the user if it's anything else, pass 3 could be improving the parser overall so this doesn't happen in the first place

It definitely should not ever fail without any warning or indication of what wrong

So, in my mind if I was patching it I would probably do a 2 or 3 phase approach. Pass 1 is just fixing the docs on the import activity

I may get around to doing these and submitting a patch for it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants