Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ten years challenge: fermions at unitarity #42

Open
ev-br opened this issue May 7, 2020 · 35 comments
Open

Ten years challenge: fermions at unitarity #42

ev-br opened this issue May 7, 2020 · 35 comments

Comments

@ev-br
Copy link

ev-br commented May 7, 2020

Original article: https://journals.aps.org/prl/abstract/10.1103/PhysRevLett.96.160402
Preprint, ungated: https://arxiv.org/abs/cond-mat/0602224

PDF URL: https://github.com/ev-br/unitarity_repro/blob/repro_unitarity/article.pdf
Metadata URL: https://github.com/ev-br/unitarity_repro/blob/repro_unitarity/metadata.yaml
Code URL: https://github.com/ev-br/10yr_repro_challenge_35/releases/tag/v1.1

Scientific domain: Physics
Programming language: Fortran / Python
Suggested editor:

This is paper 36 in ReScience/ten-years#1

@rougier
Copy link
Member

rougier commented May 14, 2020

Thanks for your (late) submission :) We'll assign an editor soon.

@pdebuyl Can you handle this submission (Physics/Python/Fortran) for the Ten Years Reproducibility Challenge (only # reviewer needed) ?

@pdebuyl
Copy link
Member

pdebuyl commented May 15, 2020

As editor thus?

@rougier
Copy link
Member

rougier commented May 19, 2020

@pdebuyl Yes, sorry, I should have explained.

@pdebuyl
Copy link
Member

pdebuyl commented May 19, 2020

ok

@pdebuyl
Copy link
Member

pdebuyl commented May 19, 2020

I mean, "I will edit" :-)

@pdebuyl
Copy link
Member

pdebuyl commented May 19, 2020

@jochym could you review the submission here? If this is your first review for ReScience, I will guide you through the process.

@pdebuyl
Copy link
Member

pdebuyl commented May 27, 2020

@dombrno could you review the submission here? If this is your first review for ReScience, I will guide you through the process.

@pdebuyl
Copy link
Member

pdebuyl commented Jun 2, 2020

@vahtras will review the paper. Thank you Olav!

@pdebuyl
Copy link
Member

pdebuyl commented Jun 11, 2020

ping @vahtras

@pdebuyl
Copy link
Member

pdebuyl commented Jun 19, 2020

@berquist would you review the submission "fermions at unitarity" for ReScience ? If this is your first review for ReScience, I will guide you through the process.

@vahtras
Copy link

vahtras commented Jun 23, 2020

Is there a howto for reviewers @pdebuyl ?

@pdebuyl
Copy link
Member

pdebuyl commented Jun 23, 2020

Hi @vahtras

We have reviewer guidelines here: https://rescience.github.io/edit/

The most specific part of the review, in relation to ReScience, is to actually run the code and verify the claims of reproduction that are stated in the article.

Specifically for the ten-year challenge

  • We only require one reviewer.
  • The requirement to have a readable and reusable code are relaxed a bit. It would make little sense for the authors of this issue to perform a full modernization of their code.
  • The author should provide in the article their reflection on the longevity, quality and retrievable character of their old code and of the corresponding environment (language, platform-specific code, proprietary tools, etc).

@ev-br
Copy link
Author

ev-br commented Jun 24, 2020

In this specific case, rerunning the full set of calculations might not be very practical, since it's going to require a non-negligible cpu time on a cluster.
Not sure what are implications though.

@pdebuyl
Copy link
Member

pdebuyl commented Jun 24, 2020

How many core-hours ? (or core-days / node-days depending on the hardware you have used)?

@ev-br
Copy link
Author

ev-br commented Jun 24, 2020

The largest runs in the supplement repository are some 120 CPU hours on 24 cores. Multiply it by about 1.5-2 for thermalization.
Smaller system sizes are much faster, some 4-10 cpu hours each, if a partial verification is OK. (rerun small system sizes on the reviewer's machine, rerun the fits with a mix of reviewer's data and my data or somesuch).

@pdebuyl
Copy link
Member

pdebuyl commented Jun 26, 2020

Well, this seems indeed costly. @vahtras do you have the resources for the small systems verification? (4-10 cpu hours each) ? I could execute that if necessary.

@pdebuyl
Copy link
Member

pdebuyl commented Jul 30, 2020

Hi all,

I see only now that the review process is frozen here. @vahtras what do you think of the computational requirements?

@vahtras
Copy link

vahtras commented Aug 11, 2020 via email

@pdebuyl
Copy link
Member

pdebuyl commented Aug 11, 2020

Hi @vahtras thank you for getting back to us :-) Other papers are still in the pipeline, so this should be ok.

@ev-br
Copy link
Author

ev-br commented Aug 15, 2020

Anything needed from me at this stage?

@rougier
Copy link
Member

rougier commented Aug 17, 2020

I think we're waiting for @vahtras review (gentle pressure :) )

@pdebuyl
Copy link
Member

pdebuyl commented Sep 7, 2020

@vahtras do you still plan to review the article?

@vahtras
Copy link

vahtras commented Sep 9, 2020

Yes, finally. First question: the makefile has been hardcoded for Intel compilers. Does it build with GNU?

@ev-br
Copy link
Author

ev-br commented Sep 9, 2020

It certainly does. ev-br/10yr_repro_challenge_35@837038f is the relevant makefile.

I then simply commented it out when transferring to cluster/intel compiler instead of adding platform detection (more brittle stuff to debug ten years down the line)

The change from gnu on a laptop to intel on cluster is here:
ev-br/10yr_repro_challenge_35@3603020

EDIT:the switch from gnu to intel is
ev-br/10yr_repro_challenge_35@acc2974

@rougier
Copy link
Member

rougier commented May 28, 2021

@pdebuyl Any progress?

@pdebuyl
Copy link
Member

pdebuyl commented Jun 22, 2021

Hi @rougier sorry about this. @vahtras is this still doable for you? In the meantime, I will try to find another reviewer.

@vahtras
Copy link

vahtras commented Jun 23, 2021 via email

@rougier
Copy link
Member

rougier commented Jun 29, 2021

@pdebuyl I think you need to find a new reviewer. You can use the @ ReScience/reviewers notification if necessary.

@pdebuyl
Copy link
Member

pdebuyl commented Jun 29, 2021

@rougier I have started to do so.

@rougier
Copy link
Member

rougier commented Jul 5, 2021

Good. Any progress?

@pdebuyl
Copy link
Member

pdebuyl commented Jul 5, 2021

Yes, I have a candidate reviewer but am waiting for confirmation before putting it here.

@rougier
Copy link
Member

rougier commented Jul 12, 2021

Gentle reminder

@pdebuyl
Copy link
Member

pdebuyl commented Jul 22, 2021

Hi @rougier unfortunately I "lost" my candidate reviewer. In all fairness (and despite the already long delay), I'd prefer to wait mid-august to look again the mid-summer is a really bad time to find reviewers!

PS: I'll also consider reviewing the paper and have Konrad or someone else be editor (august as well I am not in office)

@rougier
Copy link
Member

rougier commented Jul 27, 2021

Ok. Note that according to our process, you can serve as 2nd reviewer while being the editor.

@rougier
Copy link
Member

rougier commented May 24, 2022

Any progress?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants