Remove redundant addition of JMH to classpath (#7257)

benjamintboyle · web-flow · commit 8fb4640688a1 · 2021-05-05T22:54:51.000+02:00
Remove manual addition of JMH classpath in build file. Gradle adds classpath
for all sourceSets to Eclipse by default as fixed in Gradle 6.8 by PR
14534. The JMH sourceSet is added by the JMH Plugin.

Tested by running 'eclipse' task in Eclipse 2021-03 (4.19.0). Then refreshing,
and JMH still on classpath and viewable in Eclipse. Then removed project from
Eclipse, ran 'cleanEclipse', and re-imported project to Eclipse. All successful.
diff --git a/build.gradle b/build.gradle
@@ -126,10 +126,6 @@ jmh {
     }
 }
 
-plugins.withType(EclipsePlugin) {
-    project.eclipse.classpath.plusConfigurations += [configurations.jmh]
-}
-
 test {
     testLogging  {
         // showing skipped occasionally should prevent CI timeout due to lack of standard output

Original file line number	Diff line number	Diff line change
`@@ -126,10 +126,6 @@ jmh {`
`126`	`126`	`}`
`127`	`127`	`}`
`128`	`128`
`129`		`-plugins.withType(EclipsePlugin) {`
`130`		`- project.eclipse.classpath.plusConfigurations += [configurations.jmh]`
`131`		`-}`
`132`		`-`
`133`	`129`	`test {`
`134`	`130`	`testLogging {`
`135`	`131`	`// showing skipped occasionally should prevent CI timeout due to lack of standard output`