Missing CFBundleShortVersionString causing app upload failures on 6.10.0

[cadams-eventbase]

We use Carthage to build RxSwift and recently upgraded from 6.9.1 to 6.10.0.

After trying to upload our updated apps to App Store Connect, we were hit with this validation error from Transporter:

Validation failed (409)
The bundle 'Payload/[app-name]/Frameworks/RxCocoa.framework' is missing plist key. The Info.plist file is missing the required key: CFBundleShortVersionString.
Please find more information about CFBundleShortVersionString at https://developer.apple.com/documentation/bundleresources/information_property_list/cfbundleshortversionstring (ID: 602a4e7e-f85f-4001-8c49-ca9cf7790b40)

After inspecting the Info.plist contents in the .ipa we uploaded, this key is missing from all of the Rx frameworks.

Within the Carthage checkouts folder used to generate the .ipa, CFBundleShortVersionString is present in the Rx Info.plists, but they're all set to $(RX_VERSION) instead of a version number.

Info.plist from the .ipa:

Info.plist from Carthage:

[freak4pc]

The RX_VERSION is supposed to be derived from the included xcconfig. That's what we see on CI, too. If you have an issue where this doesn't happen, happy to accept a PR for it. Thanks!

[r-plus]

We encountered same error with RxSwift 6.10.1

[03:54:17]: Error uploading ipa file:
[Application Loader Error Output]: [ContentDelivery.Uploader.6000018C84C0]
[Application Loader Error Output]: [altool.6000018C84C0] Validation failed (409) The bundle 'Payload/My.app/Frameworks/RxCocoa.framework' is missing plist key. The Info.plist file is missing the required key: CFBundleShortVersionString. Please find more information about CFBundleShortVersionString at https://developer.apple.com/documentation/bundleresources/information_property_list/cfbundleshortversionstring (ID: d50a6294-95e2-4f7b-bf6a-20fc9128c92b)

We using XCODE_XCCONFIG_FILE environment variable to override some code sign configuration before build via carthage.
Is this cause?

[ori-hime]

Hi team,

I've just submitted a pull request that should fix this issue: #2696

I'd appreciate it if you could take a look when you have a moment. Thank you!