Tasks starting signal #142
Closed
oliverhaas
started this conversation in
Ideas
Replies: 1 comment 3 replies
-
I think there was a reason I did this, I just forget what it was. What do you see these signals being used for? Besides logging and observability? It's possible there'd be a way to use it to skip tasks (eg deduplication), but many other uses could lead to people just introducing more bugs. It's not a No, not by a long shot. I'm just interested in the use case (mostly to avoid scope creep). |
Beta Was this translation helpful? Give feedback.
3 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
Really happy that this package (and the integration in django) is happening. 😄
I just skimmed over the codebase, and I noticed there is no "task starting/started" signal. I've missed such a signal in other task packages, so I'd thought it might be a good addition, and maybe an easy entry point to get involved and start working with django-tasks.
Just for illustration puposes and untested, here is basically what I mean put in code:
https://github.com/oliverhaas/django-tasks/pull/1/files
Does this make sense, or am I missing a good reason why many task libraries just have enqueue and finished signals?
Beta Was this translation helpful? Give feedback.
All reactions