From 6ac4fbe69ff08d2c7c9222bb9fc470b30e1cc31e Mon Sep 17 00:00:00 2001 From: "helmi.nour" Date: Fri, 30 Sep 2022 15:16:17 +0100 Subject: [PATCH 1/6] run CI workflow on windows & linux --- .github/workflows/sdk.yaml | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/.github/workflows/sdk.yaml b/.github/workflows/sdk.yaml index 306a273..400307a 100644 --- a/.github/workflows/sdk.yaml +++ b/.github/workflows/sdk.yaml @@ -4,7 +4,11 @@ on: [push] jobs: sdk: - runs-on: ubuntu-latest + runs-on: ${{ matrix.os }} + + strategy: + matrix: + os: [ubuntu-latest, windows-latest] steps: - name: Checkout From b3d3a31efaf10f17f1c01542f826ed3ebcbd26d1 Mon Sep 17 00:00:00 2001 From: "helmi.nour" Date: Fri, 30 Sep 2022 15:21:25 +0100 Subject: [PATCH 2/6] fails fast to false --- .github/workflows/sdk.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/sdk.yaml b/.github/workflows/sdk.yaml index 400307a..8371c84 100644 --- a/.github/workflows/sdk.yaml +++ b/.github/workflows/sdk.yaml @@ -9,6 +9,7 @@ jobs: strategy: matrix: os: [ubuntu-latest, windows-latest] + fail-fast: false steps: - name: Checkout From dc32355bf73e9903e0e800adbfc21a659a4f0d96 Mon Sep 17 00:00:00 2001 From: "helmi.nour" Date: Fri, 30 Sep 2022 15:23:58 +0100 Subject: [PATCH 3/6] fix format --- .github/workflows/sdk.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/sdk.yaml b/.github/workflows/sdk.yaml index 8371c84..302c6d2 100644 --- a/.github/workflows/sdk.yaml +++ b/.github/workflows/sdk.yaml @@ -9,7 +9,7 @@ jobs: strategy: matrix: os: [ubuntu-latest, windows-latest] - fail-fast: false + fail-fast: false steps: - name: Checkout From 378097f9b7898a5aa9e08c86d2fa227ff7a97db6 Mon Sep 17 00:00:00 2001 From: "helmi.nour" Date: Fri, 30 Sep 2022 15:40:20 +0100 Subject: [PATCH 4/6] update .eslintrc --- .eslintrc | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/.eslintrc b/.eslintrc index c33d7fc..4e187b6 100644 --- a/.eslintrc +++ b/.eslintrc @@ -48,7 +48,12 @@ { "varsIgnorePattern": "^_$", "argsIgnorePattern": "^_+$" } ], "license-header/header": [ "error", "./license.ts" ], - "prettier/prettier": "error", + "prettier/prettier": [ + "error", + { + "endOfLine": "auto" + } + ], "simple-import-sort/exports": "error", "simple-import-sort/imports": "error", "import/no-named-as-default": "off", From b38dd2d6d356a889708298c7c90fb6257ff12c09 Mon Sep 17 00:00:00 2001 From: "helmi.nour" Date: Fri, 30 Sep 2022 17:46:36 +0100 Subject: [PATCH 5/6] setting eol to lf in .gitattributes --- .eslintrc | 7 +------ .gitattributes | 2 ++ 2 files changed, 3 insertions(+), 6 deletions(-) create mode 100644 .gitattributes diff --git a/.eslintrc b/.eslintrc index 4e187b6..c33d7fc 100644 --- a/.eslintrc +++ b/.eslintrc @@ -48,12 +48,7 @@ { "varsIgnorePattern": "^_$", "argsIgnorePattern": "^_+$" } ], "license-header/header": [ "error", "./license.ts" ], - "prettier/prettier": [ - "error", - { - "endOfLine": "auto" - } - ], + "prettier/prettier": "error", "simple-import-sort/exports": "error", "simple-import-sort/imports": "error", "import/no-named-as-default": "off", diff --git a/.gitattributes b/.gitattributes new file mode 100644 index 0000000..d7dbb40 --- /dev/null +++ b/.gitattributes @@ -0,0 +1,2 @@ +text eol=lf + From b18dfb8162afde5ae14bb258b1cc90dd5e89633c Mon Sep 17 00:00:00 2001 From: "helmi.nour" Date: Fri, 30 Sep 2022 17:51:19 +0100 Subject: [PATCH 6/6] update gitattributes --- .gitattributes | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.gitattributes b/.gitattributes index d7dbb40..4dc5263 100644 --- a/.gitattributes +++ b/.gitattributes @@ -1,2 +1,3 @@ -text eol=lf +*.ts text eol=lf +*.js text eol=lf