-
Notifications
You must be signed in to change notification settings - Fork 6
Open
Description
Summary
Implementation defines types Tuple
and Fact
to describe what I believe PomoLogic calls ground atom. This gets even more confusing given that PomoDB calls EAVT (4-tuples) facts
Problem
- This naming conflicts make it really difficult to build up and retain mental model of the implementation logic.
- I think
Tuple
andFact
also describe same concept but in different contexts and two names here which makes things even more confusing.
Impact
Makes it difficult to learn and contribute to the project.
Solution
- Rename
Fact
so it does not collide with a name "fact" when referencing EAVT tuples. I would propose calling itAssociation
as it associates multiple attributes and makes intuitive sense to me. Alternative it can be calledGroundAtom
which would be very clear reference to a terminology used in the spec. - Avoid name
Tuple
given how overloaded it is, even EAVTs are frequently referred as tuples (even spec the spec does it). Again I thinkAssociation
seems like an intuitive term for me but anything less overloaded would do. - Assuming
Tuple
andFact
do indeed refer to the concept of "ground atom" in different contexts it would be good to use same name (e.g. there are multipleProgram
types for different contexts) or alternatively have same term with different suffix.
Metadata
Metadata
Assignees
Labels
No labels