Skip to content

Commit 6f0a290

Browse files
RickyNotaroclaude
andcommitted
fix: trigger APK build from release-please after release
GitHub doesn't trigger workflows from GITHUB_TOKEN events, so the release:published event never fires the APK build. Instead, chain the APK build as a reusable workflow called directly by release-please after creating a release. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent e05457a commit 6f0a290

2 files changed

Lines changed: 23 additions & 6 deletions

File tree

.github/workflows/build-apk.yml

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,11 @@ on:
1111
- '.github/workflows/build-apk.yml'
1212
pull_request:
1313
branches: [master]
14-
release:
15-
types: [published]
14+
workflow_call:
15+
inputs:
16+
release_tag:
17+
type: string
18+
required: false
1619
workflow_dispatch:
1720

1821
jobs:
@@ -62,15 +65,16 @@ jobs:
6265
retention-days: 30
6366

6467
- name: Rename APK with version
65-
if: github.event_name == 'release'
68+
if: inputs.release_tag
6669
run: |
67-
VERSION="${{ github.event.release.tag_name }}"
70+
VERSION="${{ inputs.release_tag }}"
71+
VERSION="${VERSION#communauto-tools-v}"
6872
VERSION="${VERSION#v}"
6973
cp APK/android/app/build/outputs/apk/debug/app-debug.apk \
7074
APK/android/app/build/outputs/apk/debug/communauto-tools-${VERSION}.apk
7175
7276
- name: Upload APK to release
73-
if: github.event_name == 'release'
74-
run: gh release upload "${{ github.event.release.tag_name }}" APK/android/app/build/outputs/apk/debug/communauto-tools-*.apk --clobber
77+
if: inputs.release_tag
78+
run: gh release upload "${{ inputs.release_tag }}" APK/android/app/build/outputs/apk/debug/communauto-tools-*.apk --clobber
7579
env:
7680
GH_TOKEN: ${{ github.token }}

.github/workflows/release-please.yml

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,22 @@ jobs:
1111
permissions:
1212
contents: write
1313
pull-requests: write
14+
outputs:
15+
release_created: ${{ steps.release.outputs.release_created }}
16+
tag_name: ${{ steps.release.outputs.tag_name }}
1417

1518
steps:
1619
- uses: googleapis/release-please-action@v4
20+
id: release
1721
with:
1822
config-file: release-please-config.json
1923
manifest-file: .release-please-manifest.json
24+
25+
build-apk:
26+
needs: release-please
27+
if: needs.release-please.outputs.release_created == 'true'
28+
uses: ./.github/workflows/build-apk.yml
29+
with:
30+
release_tag: ${{ needs.release-please.outputs.tag_name }}
31+
permissions:
32+
contents: write

0 commit comments

Comments
 (0)