Skip to content

Conversation

@roomote
Copy link
Contributor

@roomote roomote bot commented Nov 8, 2025

Per Z.ai guidance: GLM-4.5 and GLM-4.6 coding agents were trained without think data. This change removes supportsReasoningBinary from these models so the UI hides thinking controls and the backend no longer sends thinking params. Also adds a concise note in the Z AI provider settings: "For coding agents, GLM-4.5/4.6 have no think; thinking will be available in GLM-4.6 Air." Tests updated and passing.


Important

Disable 'thinking' controls for GLM-4.5/4.6 models and update UI to reflect this change.

  • Behavior:
    • Removes supportsReasoningBinary from GLM-4.5 and GLM-4.6 models in zai.ts to disable 'thinking' controls.
    • Updates test cases in zai.spec.ts to ensure 'thinking' parameters are not included for GLM-4.5/4.6.
  • UI:
    • Adds note in ZAi.tsx and updates translations in settings.json files across multiple languages to inform users that 'thinking' is unavailable for GLM-4.5/4.6.

This description was created by Ellipsis for a4e093d. You can customize this summary. It will automatically update as commits are pushed.

@roomote roomote bot requested review from cte, jr and mrubens as code owners November 8, 2025 22:35
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. UI/UX UI/UX related or focused labels Nov 8, 2025
@roomote
Copy link
Contributor Author

roomote bot commented Nov 8, 2025

Rooviewer Clock   See task on Roo Cloud

Re-review complete. No new issues found.

Previous reviews

Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues.

@hannesrudolph hannesrudolph added the Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. label Nov 8, 2025
"maxTokensDescription": "Claude Code 响应的最大输出 Token 数量。默认为 8000。"
}
},
"zaiThinkNote": "Note: For coding agents, GLM-4.5 and GLM-4.6 were trained without 'think'. Thinking will be available in GLM-4.6 Air."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new key zaiThinkNote is added with an English string. Please ensure that for non‐English locales you provide proper translations rather than using the English fallback, in accordance with our i18n best practices.

Suggested change
"zaiThinkNote": "Note: For coding agents, GLM-4.5 and GLM-4.6 were trained without 'think'. Thinking will be available in GLM-4.6 Air."
"zaiThinkNote": "注意:对于编码代理,GLM-4.5 GLM-4.6 训练时未包含 'think'GLM-4.6 Air 将支持思考功能。"

This comment was generated because it violated a code review rule: irule_C0ez7Rji6ANcGkkX.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. size:S This PR changes 10-29 lines, ignoring generated files. UI/UX UI/UX related or focused

Projects

Status: Triage

Development

Successfully merging this pull request may close these issues.

3 participants