Skip to content

Conversation

@roomote
Copy link
Contributor

@roomote roomote bot commented Nov 11, 2025

Description

This PR attempts to address Issue #9163. When editing a message, the redundant mode selector, API config selector, and auto-approve dropdown controls are now hidden to keep the editing interface clean.

Changes

  • Wrapped the bottom controls section in ChatTextArea.tsx with a conditional check for !isEditMode
  • This prevents duplicate controls from appearing since these options already exist at the bottom of the main chat interface

Testing

  • All existing tests pass
  • Linting passes
  • Type checking passes

Screenshots

The editing interface now only shows the necessary editing controls without the redundant bottom bar.

Fixes #9163

Feedback and guidance are welcome!


Important

Hides redundant UI controls in ChatTextArea.tsx during message editing to improve interface clarity.

  • Behavior:
    • Hides ModeSelector, ApiConfigSelector, and AutoApproveDropdown in ChatTextArea.tsx when isEditMode is true.
    • Ensures these controls are only visible in non-edit mode to prevent redundancy.
  • Testing:
    • All existing tests, linting, and type checking pass.

This description was created by Ellipsis for 91f4898. You can customize this summary. It will automatically update as commits are pushed.

- Hide ModeSelector, ApiConfigSelector, and AutoApproveDropdown when isEditMode is true
- Keeps the editing interface clean and prevents duplicate controls
- Fixes #9163
@roomote roomote bot requested review from cte, jr and mrubens as code owners November 11, 2025 05:41
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. UI/UX UI/UX related or focused labels Nov 11, 2025
@roomote
Copy link
Contributor Author

roomote bot commented Nov 11, 2025

Rooviewer Clock   See task on Roo Cloud

Review complete. The implementation correctly wraps the bottom controls section with !isEditMode conditional logic, successfully hiding the redundant ModeSelector, ApiConfigSelector, and AutoApproveDropdown when editing messages. The change is clean, follows existing patterns, and addresses issue #9163 without introducing any issues.

Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues.

@hannesrudolph hannesrudolph added the Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. label Nov 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. size:L This PR changes 100-499 lines, ignoring generated files. UI/UX UI/UX related or focused

Projects

Status: Triage

Development

Successfully merging this pull request may close these issues.

[ENHANCEMENT] Remove redundant double options when editing a message

3 participants