fix: handle npx with package@version syntax on Windows for MCP servers #9168
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to address Issue #9167. Feedback and guidance are welcome.
Problem
The chrome-devtools-mcp server was not being detected when configured with
npx chrome-devtools-mcp@lateston Windows systems. This was due to how the command was being wrapped withcmd.exefor Windows compatibility.Solution
Added special handling for
npxcommands that include@in the package name (e.g.,chrome-devtools-mcp@latest):npxis used with a package containing@, we now combinenpxand the package name into a single command stringcmd.exeChanges
McpHub.tsto detect and handlenpxwith versioned packagesnpx package@versionsyntaxnpx package@versionwith additional argumentsTesting
Fixes #9167
Important
Fixes handling of
npxwithpackage@versionsyntax on Windows inMcpHub.ts, ensuring proper command execution withcmd.exe.npxcommands withpackage@versionsyntax on Windows inMcpHub.ts.npxand package name into a single command string for Windows compatibility.cmd.exe.McpHub.spec.tsfornpx package@versionsyntax handling on Windows.cmd.exe.This description was created by
for 14a8021. You can customize this summary. It will automatically update as commits are pushed.