Skip to content

Commit 6ca14a2

Browse files
committed
fix docker compose for root and client - everything integrates together!
1 parent f6baaf6 commit 6ca14a2

File tree

4 files changed

+21
-21
lines changed

4 files changed

+21
-21
lines changed

Makefile

-1
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@ remove:
88
sudo docker-compose down --remove-orphans
99

1010
build:
11-
cd server && dotnet publish -c Release && cd ..
1211
sudo docker-compose -f docker-compose.dev.yml up --build
1312

1413
up:

client/Dockerfile

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
1-
FROM node
1+
FROM node:10
22

33
WORKDIR /App
44

55
COPY ./package.json ./yarn.lock /App/
66

7-
RUN yarn
7+
RUN yarn && yarn add [email protected] && npm rebuild node-sass
88

99
COPY ./ /App/
1010

client/README.md

+2-1
Original file line numberDiff line numberDiff line change
@@ -11,4 +11,5 @@
1111

1212
## References
1313

14-
- [Create-React-App with TypeScript, ESLint, Prettier, and Github Actions](https://medium.com/@brygrill/create-react-app-with-typescript-eslint-prettier-and-github-actions-f3ce6a571c97)
14+
- [Create-React-App with TypeScript, ESLint, Prettier, and Github Actions](https://medium.com/@brygrill/create-react-app-with-typescript-eslint-prettier-and-github-actions-f3ce6a571c97)
15+
- [Dotnet Docker - Github Repository](https://github.com/dotnet/dotnet-docker)

docker-compose.dev.yml

+17-17
Original file line numberDiff line numberDiff line change
@@ -11,30 +11,30 @@ services:
1111
- ./web-server/nginx.conf:/etc/nginx/nginx.conf
1212
ports:
1313
- "8080:8080"
14-
# depends_on:
15-
# - client
16-
# - server
17-
# - smtp
18-
# - postgres
19-
# - mongo
20-
# - cache
14+
depends_on:
15+
- client
16+
- server
17+
- smtp
18+
- postgres
19+
- mongo
20+
- cache
2121

22-
# client:
23-
# container_name: client
24-
# build: ./client
25-
# stdin_open: true
26-
# restart: always
27-
# volumes:
28-
# - "./client:/App"
29-
# ports:
30-
# - "3000:3000"
22+
client:
23+
container_name: client
24+
build: ./client
25+
stdin_open: true
26+
restart: always
27+
volumes:
28+
- "./client:/App"
29+
ports:
30+
- "3000:3000"
3131

3232
server:
3333
container_name: backend
3434
build: ./server
3535
restart: always
3636
volumes:
37-
- "./server:/Backend"
37+
- "./server:/backend"
3838
ports:
3939
- "5000:5000" # For HTTP
4040
- "5001:5001" # For HTTPS

0 commit comments

Comments
 (0)