Skip to content

Commit 36bc511

Browse files
olsajiriacmel
authored andcommitted
perf daemon: Fix running test for non root user
John reported that the daemon test is not working for non root user. Changing the tests configurations so it's allowed to run under normal user. Fixes: 2291bb9 ("perf tests: Add daemon 'list' command test") Reported-by: John Garry <[email protected]> Signed-off-by: Jiri Olsa <[email protected]> Tested-by: John Garry <[email protected]> Cc: Alexander Shishkin <[email protected]> Cc: Ian Rogers <[email protected]> Cc: Mark Rutland <[email protected]> Cc: Michael Petlan <[email protected]> Cc: Namhyung Kim <[email protected]> Cc: Peter Zijlstra <[email protected]> Link: http://lore.kernel.org/lkml/[email protected] Signed-off-by: Arnaldo Carvalho de Melo <[email protected]>
1 parent 31bf4e7 commit 36bc511

File tree

1 file changed

+16
-16
lines changed

1 file changed

+16
-16
lines changed

tools/perf/tests/shell/daemon.sh

+16-16
Original file line numberDiff line numberDiff line change
@@ -140,10 +140,10 @@ test_list()
140140
base=BASE
141141
142142
[session-size]
143-
run = -e cpu-clock
143+
run = -e cpu-clock -m 1 sleep 10
144144
145145
[session-time]
146-
run = -e task-clock
146+
run = -e task-clock -m 1 sleep 10
147147
EOF
148148

149149
sed -i -e "s|BASE|${base}|" ${config}
@@ -159,14 +159,14 @@ EOF
159159
# check 1st session
160160
# pid:size:-e cpu-clock:base/size:base/size/output:base/size/control:base/size/ack:0
161161
local line=`perf daemon --config ${config} -x: | head -2 | tail -1`
162-
check_line_other "${line}" size "-e cpu-clock" ${base}/session-size \
162+
check_line_other "${line}" size "-e cpu-clock -m 1 sleep 10" ${base}/session-size \
163163
${base}/session-size/output ${base}/session-size/control \
164164
${base}/session-size/ack "0"
165165

166166
# check 2nd session
167167
# pid:time:-e task-clock:base/time:base/time/output:base/time/control:base/time/ack:0
168168
local line=`perf daemon --config ${config} -x: | head -3 | tail -1`
169-
check_line_other "${line}" time "-e task-clock" ${base}/session-time \
169+
check_line_other "${line}" time "-e task-clock -m 1 sleep 10" ${base}/session-time \
170170
${base}/session-time/output ${base}/session-time/control \
171171
${base}/session-time/ack "0"
172172

@@ -190,10 +190,10 @@ test_reconfig()
190190
base=BASE
191191
192192
[session-size]
193-
run = -e cpu-clock
193+
run = -e cpu-clock -m 1 sleep 10
194194
195195
[session-time]
196-
run = -e task-clock
196+
run = -e task-clock -m 1 sleep 10
197197
EOF
198198

199199
sed -i -e "s|BASE|${base}|" ${config}
@@ -204,7 +204,7 @@ EOF
204204
# check 2nd session
205205
# pid:time:-e task-clock:base/time:base/time/output:base/time/control:base/time/ack:0
206206
local line=`perf daemon --config ${config} -x: | head -3 | tail -1`
207-
check_line_other "${line}" time "-e task-clock" ${base}/session-time \
207+
check_line_other "${line}" time "-e task-clock -m 1 sleep 10" ${base}/session-time \
208208
${base}/session-time/output ${base}/session-time/control ${base}/session-time/ack "0"
209209
local pid=`echo "${line}" | awk 'BEGIN { FS = ":" } ; { print $1 }'`
210210

@@ -215,10 +215,10 @@ EOF
215215
base=BASE
216216
217217
[session-size]
218-
run = -e cpu-clock
218+
run = -e cpu-clock -m 1 sleep 10
219219
220220
[session-time]
221-
run = -e cpu-clock
221+
run = -e cpu-clock -m 1 sleep 10
222222
EOF
223223

224224
# TEST 1 - change config
@@ -238,7 +238,7 @@ EOF
238238
# check reconfigured 2nd session
239239
# pid:time:-e task-clock:base/time:base/time/output:base/time/control:base/time/ack:0
240240
local line=`perf daemon --config ${config} -x: | head -3 | tail -1`
241-
check_line_other "${line}" time "-e cpu-clock" ${base}/session-time \
241+
check_line_other "${line}" time "-e cpu-clock -m 1 sleep 10" ${base}/session-time \
242242
${base}/session-time/output ${base}/session-time/control ${base}/session-time/ack "0"
243243

244244
# TEST 2 - empty config
@@ -309,10 +309,10 @@ test_stop()
309309
base=BASE
310310
311311
[session-size]
312-
run = -e cpu-clock
312+
run = -e cpu-clock -m 1 sleep 10
313313
314314
[session-time]
315-
run = -e task-clock
315+
run = -e task-clock -m 1 sleep 10
316316
EOF
317317

318318
sed -i -e "s|BASE|${base}|" ${config}
@@ -361,7 +361,7 @@ test_signal()
361361
base=BASE
362362
363363
[session-test]
364-
run = -e cpu-clock --switch-output
364+
run = -e cpu-clock --switch-output -m 1 sleep 10
365365
EOF
366366

367367
sed -i -e "s|BASE|${base}|" ${config}
@@ -400,10 +400,10 @@ test_ping()
400400
base=BASE
401401
402402
[session-size]
403-
run = -e cpu-clock
403+
run = -e cpu-clock -m 1 sleep 10
404404
405405
[session-time]
406-
run = -e task-clock
406+
run = -e task-clock -m 1 sleep 10
407407
EOF
408408

409409
sed -i -e "s|BASE|${base}|" ${config}
@@ -439,7 +439,7 @@ test_lock()
439439
base=BASE
440440
441441
[session-size]
442-
run = -e cpu-clock
442+
run = -e cpu-clock -m 1 sleep 10
443443
EOF
444444

445445
sed -i -e "s|BASE|${base}|" ${config}

0 commit comments

Comments
 (0)