Skip to content

Commit c6cf0b6

Browse files
zhengchaoshaoSaeed Mahameed
authored and
Saeed Mahameed
committed
net/mlx5: fix potential memory leak in mlx5e_init_rep_rx
The memory pointed to by the priv->rx_res pointer is not freed in the error path of mlx5e_init_rep_rx, which can lead to a memory leak. Fix by freeing the memory in the error path, thereby making the error path identical to mlx5e_cleanup_rep_rx(). Fixes: af8bbf7 ("net/mlx5e: Convert mlx5e_flow_steering member of mlx5e_priv to pointer") Signed-off-by: Zhengchao Shao <[email protected]> Reviewed-by: Simon Horman <[email protected]> Reviewed-by: Tariq Toukan <[email protected]> Signed-off-by: Saeed Mahameed <[email protected]>
1 parent 5dd7758 commit c6cf0b6

File tree

1 file changed

+2
-1
lines changed
  • drivers/net/ethernet/mellanox/mlx5/core

1 file changed

+2
-1
lines changed

drivers/net/ethernet/mellanox/mlx5/core/en_rep.c

+2-1
Original file line numberDiff line numberDiff line change
@@ -1012,7 +1012,7 @@ static int mlx5e_init_rep_rx(struct mlx5e_priv *priv)
10121012
err = mlx5e_open_drop_rq(priv, &priv->drop_rq);
10131013
if (err) {
10141014
mlx5_core_err(mdev, "open drop rq failed, %d\n", err);
1015-
return err;
1015+
goto err_rx_res_free;
10161016
}
10171017

10181018
err = mlx5e_rx_res_init(priv->rx_res, priv->mdev, 0,
@@ -1046,6 +1046,7 @@ static int mlx5e_init_rep_rx(struct mlx5e_priv *priv)
10461046
mlx5e_rx_res_destroy(priv->rx_res);
10471047
err_close_drop_rq:
10481048
mlx5e_close_drop_rq(&priv->drop_rq);
1049+
err_rx_res_free:
10491050
mlx5e_rx_res_free(priv->rx_res);
10501051
priv->rx_res = NULL;
10511052
err_free_fs:

0 commit comments

Comments
 (0)