perf: add inline hints to into_inner and I/O methods

Add #[inline] attributes to:
- into_inner() methods across decoders (WAV, Vorbis, Symphonia)
- read() and seek() implementations for ReadSeekSource

These simple pass-through methods are good candidates for inlining as they
just forward calls to their inner types without additional logic.

Author: roderickvd

benches/shared.rs

@@ -14,30 +14,36 @@ pub struct TestSource<T> {
 impl<T> Iterator for TestSource<T> {
     type Item = T;
 
+    #[inline]
     fn next(&mut self) -> Option<Self::Item> {
         self.samples.next()
     }
 }
 
 impl<T> ExactSizeIterator for TestSource<T> {
+    #[inline]
     fn len(&self) -> usize {
         self.samples.len()
     }
 }
 
 impl<T: Sample> Source for TestSource<T> {
+    #[inline]
     fn current_span_len(&self) -> Option<usize> {
         None // forever
     }
 
+    #[inline]
     fn channels(&self) -> ChannelCount {
         self.channels
     }
 
+    #[inline]
     fn sample_rate(&self) -> SampleRate {
         self.sample_rate
     }
 
+    #[inline]
     fn total_duration(&self) -> Option<Duration> {
         Some(self.total_duration)
     }

src/conversions/mod.rs

@@ -11,7 +11,5 @@ pub use self::sample::Sample;
 pub use self::sample_rate::SampleRateConverter;
 
 mod channels;
-// TODO: < shouldn't be public ; there's a bug in Rust 1.4 and below that makes This
-// `pub` mandatory
-pub mod sample;
+mod sample;
 mod sample_rate;

src/decoder/flac.rs

@@ -67,6 +67,7 @@ where
         })
     }
 
+    #[inline]
     pub fn into_inner(self) -> R {
         self.reader.into_inner()
     }

src/decoder/mp3.rs

@@ -45,6 +45,8 @@ where
             current_span_offset: 0,
         })
     }
+
+    #[inline]
     pub fn into_inner(self) -> R {
         self.decoder.into_inner()
     }

src/decoder/read_seek_source.rs

@@ -9,28 +9,33 @@ pub struct ReadSeekSource<T: Read + Seek + Send + Sync> {
 impl<T: Read + Seek + Send + Sync> ReadSeekSource<T> {
     /// Instantiates a new `ReadSeekSource<T>` by taking ownership and wrapping the provided
     /// `Read + Seek`er.
+    #[inline]
     pub fn new(inner: T) -> Self {
         ReadSeekSource { inner }
     }
 }
 
 impl<T: Read + Seek + Send + Sync> MediaSource for ReadSeekSource<T> {
+    #[inline]
     fn is_seekable(&self) -> bool {
         true
     }
 
+    #[inline]
     fn byte_len(&self) -> Option<u64> {
         None
     }
 }
 
 impl<T: Read + Seek + Send + Sync> Read for ReadSeekSource<T> {
+    #[inline]
     fn read(&mut self, buf: &mut [u8]) -> Result<usize> {
         self.inner.read(buf)
     }
 }
 
 impl<T: Read + Seek + Send + Sync> Seek for ReadSeekSource<T> {
+    #[inline]
     fn seek(&mut self, pos: SeekFrom) -> Result<u64> {
         self.inner.seek(pos)
     }

src/decoder/symphonia.rs

@@ -53,6 +53,7 @@ impl SymphoniaDecoder {
         }
     }
 
+    #[inline]
     pub(crate) fn into_inner(self) -> MediaSourceStream {
         self.format.into_inner()
     }

src/decoder/vorbis.rs

@@ -54,6 +54,8 @@ where
             next: 0,
         }
     }
+
+    #[inline]
     pub fn into_inner(self) -> OggStreamReader<R> {
         self.stream_reader
     }

src/decoder/wav.rs

@@ -58,6 +58,7 @@ where
         })
     }
 
+    #[inline]
     pub fn into_inner(self) -> R {
         self.reader.reader.into_inner()
     }