ocb3: enable and fix workspace-level lints (#848)

Author: tarcieri

ocb3/Cargo.toml

@@ -37,6 +37,8 @@ bytes = ["aead/bytes"]
 getrandom = ["aead/getrandom"]
 rand_core = ["aead/rand_core"]
 
+[lints]
+workspace = true
+
 [package.metadata.docs.rs]
 all-features = true
-rustdoc-args = ["--cfg", "docsrs"]

ocb3/src/lib.rs

@@ -5,8 +5,7 @@
     html_logo_url = "https://raw.githubusercontent.com/RustCrypto/meta/master/logo.svg",
     html_favicon_url = "https://raw.githubusercontent.com/RustCrypto/meta/master/logo.svg"
 )]
-#![deny(unsafe_code)]
-#![warn(missing_docs, rust_2018_idioms)]
+#![allow(clippy::explicit_counter_loop)]
 
 /// Constants used, reexported for convenience.
 pub mod consts {
@@ -28,7 +27,7 @@ use cipher::{
     consts::{U2, U12, U16},
     typenum::Prod,
 };
-use core::marker::PhantomData;
+use core::{fmt, marker::PhantomData};
 use dbl::Dbl;
 use subtle::ConstantTimeEq;
 
@@ -204,7 +203,7 @@ where
     ) -> aead::Result<aead::Tag<Self>> {
         let max_len = 1 << (L_TABLE_SIZE + 4);
         if (buffer.len() >= max_len) || (associated_data.len() >= max_len) {
-            return Err(aead::Error);
+            return Err(Error);
         }
 
         // First, try to process many blocks at once.
@@ -287,7 +286,7 @@ where
     ) -> aead::Result<aead::Tag<Self>> {
         let max_len = 1 << (L_TABLE_SIZE + 4);
         if (buffer.len() > max_len) || (associated_data.len() > max_len) {
-            return Err(aead::Error);
+            return Err(Error);
         }
 
         // First, try to process many blocks at once.
@@ -477,6 +476,18 @@ where
     }
 }
 
+impl<Cipher, NonceSize, TagSize, const L_TABLE_SIZE: usize> fmt::Debug
+    for Ocb3<Cipher, NonceSize, TagSize, L_TABLE_SIZE>
+where
+    Cipher: KeySizeUser,
+    NonceSize: sealed::NonceSizes,
+    TagSize: sealed::TagSizes,
+{
+    fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
+        f.debug_struct("Ocb3").finish_non_exhaustive()
+    }
+}
+
 /// Computes key-dependent variables defined in
 /// https://www.rfc-editor.org/rfc/rfc7253.html#section-4.1
 fn key_dependent_variables<Cipher, const L_TABLE_SIZE: usize>(
@@ -494,13 +505,14 @@ where
     #[allow(clippy::needless_range_loop)]
     for i in 0..L_TABLE_SIZE {
         ll_i = ll_i.dbl();
-        ll[i] = ll_i
+        ll[i] = ll_i;
     }
     (ll_star, ll_dollar, ll)
 }
 
 /// Computes nonce-dependent variables as defined
 /// in https://www.rfc-editor.org/rfc/rfc7253.html#section-4.2
+#[allow(clippy::cast_possible_truncation, reason = "TODO")]
 fn nonce_dependent_variables<
     Cipher: BlockSizeUser<BlockSize = U16> + BlockCipherEncrypt,
     NonceSize: sealed::NonceSizes,
@@ -540,6 +552,7 @@ fn nonce_dependent_variables<
 
 /// Computes the initial offset as defined
 /// in https://www.rfc-editor.org/rfc/rfc7253.html#section-4.2
+#[allow(clippy::unwrap_used)]
 fn initial_offset<
     Cipher: BlockSizeUser<BlockSize = U16> + BlockCipherEncrypt,
     NonceSize: sealed::NonceSizes,

ocb3/tests/kats.rs

@@ -1,4 +1,7 @@
+//! OCB3 Known Answer Tests (KATs).
+
 #![allow(non_snake_case)]
+#![allow(clippy::unwrap_used, reason = "tests")]
 
 use aead::{
     AeadInOut, KeyInit,
@@ -103,8 +106,8 @@ type Aes256Ocb3Tag96 = Ocb3<Aes256, U12, U12>;
 type Aes128Ocb3Tag64 = Ocb3<Aes128, U12, U8>;
 type Aes192Ocb3Tag64 = Ocb3<Aes192, U12, U8>;
 type Aes256Ocb3Tag64 = Ocb3<Aes256, U12, U8>;
-type Aes128Ocb3 = Ocb3<aes::Aes128, U12>;
-type Aes256Ocb3 = Ocb3<aes::Aes256, U12>;
+type Aes128Ocb3 = Ocb3<Aes128, U12>;
+type Aes256Ocb3 = Ocb3<Aes256, U12>;
 
 /// Test vectors from Page 18 of https://www.rfc-editor.org/rfc/rfc7253.html#appendix-A
 #[test]

ocb3/tests/len_check.rs

@@ -1,3 +1,5 @@
+//! Length check tests.
+
 use aead::{
     AeadInOut, KeyInit,
     consts::{U12, U16},