ascon-aead128: enable and fix workspace-level lints (#842)

Author: tarcieri

ascon-aead128/Cargo.toml

@@ -29,6 +29,9 @@ getrandom = ["aead/getrandom"]
 rand_core = ["aead/rand_core"]
 zeroize = ["dep:zeroize", "ascon/zeroize"]
 
+[lints]
+workspace = true
+
 [package.metadata.docs.rs]
 all-features = true
 rustdoc-args = ["--cfg", "docsrs"]

ascon-aead128/LICENSE-MIT

@@ -1,5 +1,5 @@
 Copyright (c) 2021-2023 Sebastian Ramacher <sebastian.ramacher@ait.ac.at>
-Copyright (c) 2023 The RustCrypto Project Developers
+Copyright (c) 2023-2026 The RustCrypto Project Developers
 
 Permission is hereby granted, free of charge, to any
 person obtaining a copy of this software and associated

ascon-aead128/src/asconcore.rs

@@ -22,10 +22,11 @@ const fn clear(word: u64, n: usize) -> u64 {
 // Helper functions to convert &[u8] to u64. Once the `processing_*`
 // functions are rewritten with `as_chunks`, they can be dropped.
 
+// Note: function is always called with slices of the correct size
 #[inline]
 fn u64_from_bytes(input: &[u8]) -> u64 {
-    // Soundness: function is always called with slices of the correct size
-    u64::from_le_bytes(input.try_into().unwrap())
+    debug_assert_eq!(input.len(), 8);
+    u64::from_le_bytes(input.try_into().expect("input should be 8-bytes long"))
 }
 
 #[inline]

ascon-aead128/src/lib.rs

@@ -1,11 +1,10 @@
 #![no_std]
-#![cfg_attr(docsrs, feature(doc_auto_cfg))]
+#![cfg_attr(docsrs, feature(doc_cfg))]
 #![doc = include_str!("../README.md")]
 #![doc(
     html_logo_url = "https://raw.githubusercontent.com/RustCrypto/meta/master/logo.svg",
     html_favicon_url = "https://raw.githubusercontent.com/RustCrypto/meta/master/logo.svg"
 )]
-#![warn(missing_docs)]
 
 //! ## Usage
 //!
@@ -84,15 +83,15 @@
 //! # }
 //! ```
 
+mod asconcore;
+
+pub use aead::{self, Error, Key, Nonce, Tag};
 #[cfg(feature = "zeroize")]
 pub use zeroize;
 
-pub use aead::{self, Error, Key, Nonce, Tag};
 use aead::{AeadCore, AeadInOut, KeyInit, KeySizeUser, TagPosition, consts::U16, inout::InOutBuf};
-
-mod asconcore;
-
 use asconcore::{AsconCore, Parameters, Parameters128};
+use core::fmt;
 
 /// Ascon generic over some Parameters
 ///
@@ -207,3 +206,9 @@ impl AeadInOut for AsconAead128 {
             .decrypt_inout_detached(nonce, associated_data, buffer, tag)
     }
 }
+
+impl fmt::Debug for AsconAead128 {
+    fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
+        f.debug_struct("AsconAead128").finish_non_exhaustive()
+    }
+}

ascon-aead128/tests/reference_kats.rs

@@ -1,3 +1,5 @@
+//! Ascon-AEAD128 Known Answer Tests (KATs).
+
 use ascon_aead128::AsconAead128;
 
 // Test vectors are taken from the reference Ascon implementation: