Skip to content

Commit c7c4049

Browse files
committed
Bump rand_core to v0.10.0-rc-2
Also migrates from `rand_chacha` to `chacha20` for an RNG
1 parent 56e6c4a commit c7c4049

File tree

21 files changed

+70
-37
lines changed

21 files changed

+70
-37
lines changed

Cargo.lock

Lines changed: 31 additions & 5 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Cargo.toml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,21 +23,21 @@ subtle = { version = "2.6", default-features = false }
2323
der = { version = "0.8.0-rc.9", optional = true, default-features = false }
2424
hybrid-array = { version = "0.4.5", optional = true, features = ["subtle"] }
2525
num-traits = { version = "0.2.19", default-features = false }
26-
rand_core = { version = "0.9.2", optional = true, default-features = false }
26+
rand_core = { version = "0.10.0-rc-2", optional = true, default-features = false }
2727
rlp = { version = "0.6", optional = true, default-features = false }
2828
serdect = { version = "0.4", optional = true, default-features = false }
2929
zeroize = { version = "1", optional = true, default-features = false }
3030

3131
[dev-dependencies]
3232
bincode = { version = "2", features = ["serde"] }
33+
chacha20 = { version = "0.10.0-rc.3", default-features = false, features = ["rng"] }
3334
criterion = { version = "0.7", features = ["html_reports"] }
3435
hex-literal = "1"
3536
num-bigint = "0.4"
3637
num-integer = "0.1"
3738
num-modular = { version = "0.6", features = ["num-bigint", "num-integer", "num-traits"] }
3839
proptest = "1.9"
39-
rand_core = { version = "0.9", features = ["std", "os_rng"] }
40-
rand_chacha = "0.9"
40+
rand_core = "0.10.0-rc-2"
4141

4242
[features]
4343
default = ["rand"]

src/int/div_uint.rs

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -456,12 +456,17 @@ mod tests {
456456
#[cfg(feature = "rand_core")]
457457
use {
458458
crate::{I1024, Random, U512, U1024},
459-
rand_chacha::ChaChaRng,
459+
chacha20::ChaCha8Rng,
460460
rand_core::SeedableRng,
461461
};
462462

463463
use crate::{I128, U128};
464464

465+
const SEED: [u8; 32] = [
466+
0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21, 22, 23, 24,
467+
25, 26, 27, 28, 29, 30, 31,
468+
];
469+
465470
#[test]
466471
fn test_div_uint() {
467472
// lhs = min
@@ -488,10 +493,11 @@ mod tests {
488493
assert_eq!(I128::MAX / U128::MAX.to_nz().unwrap(), I128::ZERO);
489494
}
490495

496+
// TODO(tarcieri): use proptest
491497
#[cfg(feature = "rand_core")]
492498
#[test]
493499
fn test_div_ct_vs_vt() {
494-
let mut rng = ChaChaRng::from_os_rng();
500+
let mut rng = ChaCha8Rng::from_seed(SEED);
495501
for _ in 0..50 {
496502
let num = I1024::random(&mut rng);
497503
let denom = U1024::from(&U512::random(&mut rng)).to_nz().unwrap();
@@ -556,10 +562,11 @@ mod tests {
556562
);
557563
}
558564

565+
// TODO(tarcieri): use proptest
559566
#[cfg(feature = "rand_core")]
560567
#[test]
561568
fn test_div_floor_ct_vs_vt() {
562-
let mut rng = ChaChaRng::from_os_rng();
569+
let mut rng = ChaCha8Rng::from_seed(SEED);
563570
for _ in 0..50 {
564571
let num = I1024::random(&mut rng);
565572
let denom = U1024::from(&U512::random(&mut rng)).to_nz().unwrap();

src/lib.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -119,7 +119,7 @@
119119
//! ```
120120
//! # #[cfg(feature = "rand")]
121121
//! # {
122-
//! # use rand_chacha::ChaCha8Rng;
122+
//! # use chacha20::ChaCha8Rng;
123123
//! # use rand_core::SeedableRng;
124124
//! # fn rng() -> ChaCha8Rng {
125125
//! # ChaCha8Rng::from_seed(*b"01234567890123456789012345678901")
@@ -138,7 +138,7 @@
138138
//! ```
139139
//! # #[cfg(feature = "rand")]
140140
//! # {
141-
//! # use rand_chacha::ChaCha8Rng;
141+
//! # use chacha20::ChaCha8Rng;
142142
//! # use rand_core::SeedableRng;
143143
//! # fn rng() -> ChaCha8Rng {
144144
//! # ChaCha8Rng::from_seed(*b"01234567890123456789012345678901")

src/modular/boxed_monty_form/lincomb.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ mod tests {
3838

3939
const SIZE: u32 = 511;
4040

41-
let mut rng = rand_chacha::ChaCha8Rng::seed_from_u64(1);
41+
let mut rng = chacha20::ChaCha8Rng::seed_from_u64(1);
4242
for n in 0..100 {
4343
let modulus = Odd::<BoxedUint>::random(&mut rng, SIZE);
4444
let params = BoxedMontyParams::new(modulus.clone());

src/modular/const_monty_form/lincomb.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ mod tests {
3535
);
3636
let modulus = P::PARAMS.modulus.as_nz_ref();
3737

38-
let mut rng = rand_chacha::ChaCha8Rng::seed_from_u64(1);
38+
let mut rng = chacha20::ChaCha8Rng::seed_from_u64(1);
3939
for n in 0..1000 {
4040
let a = U256::random_mod(&mut rng, modulus);
4141
let b = U256::random_mod(&mut rng, modulus);

src/modular/monty_form/lincomb.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ mod tests {
3838
};
3939
use rand_core::SeedableRng;
4040

41-
let mut rng = rand_chacha::ChaCha8Rng::seed_from_u64(1);
41+
let mut rng = chacha20::ChaCha8Rng::seed_from_u64(1);
4242
for n in 0..1500 {
4343
let modulus = Odd::<U256>::random(&mut rng);
4444
let params = MontyParams::new_vartime(modulus);

src/uint/add_mod.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@ mod tests {
8484
($size:expr, $test_name:ident) => {
8585
#[test]
8686
fn $test_name() {
87-
let mut rng = rand_chacha::ChaCha8Rng::seed_from_u64(1);
87+
let mut rng = chacha20::ChaCha8Rng::seed_from_u64(1);
8888
let moduli = [
8989
NonZero::<Limb>::random(&mut rng),
9090
NonZero::<Limb>::random(&mut rng),

src/uint/boxed/encoding.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -589,7 +589,7 @@ mod tests {
589589
fn encode_radix_round_trip() {
590590
use crate::RandomBits;
591591
use rand_core::SeedableRng;
592-
let mut rng = rand_chacha::ChaCha8Rng::seed_from_u64(1);
592+
let mut rng = chacha20::ChaCha8Rng::seed_from_u64(1);
593593

594594
for _ in 0..100 {
595595
let uint = BoxedUint::random_bits(&mut rng, 4096);

src/uint/boxed/mul.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -221,7 +221,7 @@ mod tests {
221221
fn mul_cmp() {
222222
use crate::{RandomBits, Resize};
223223
use rand_core::SeedableRng;
224-
let mut rng = rand_chacha::ChaCha8Rng::seed_from_u64(1);
224+
let mut rng = chacha20::ChaCha8Rng::seed_from_u64(1);
225225

226226
for i in 0..50 {
227227
let a = BoxedUint::random_bits(&mut rng, 4096);

0 commit comments

Comments
 (0)