test: remove internal testing of now-private structs

Author: huitseeker

blake2/tests/blake2x.rs

@@ -10,7 +10,6 @@
 #![cfg(feature = "blake2x")]
 
 use blake2::{Blake2xb, Blake2xs};
-use digest::block_api::VariableOutputCore;
 use digest::{ExtendableOutput, Update, XofReader};
 use serde::Deserialize;
 use std::fs;
@@ -459,105 +458,8 @@ fn blake2b_xof_parameter_differs_by_length() {
 }
 
 // ==== Internal Parameter Block/State Tests  ====
-
-#[test]
-fn blake2s_xof_parameter_placement() {
-    use blake2::Blake2xsCore;
-    use blake2::simd::u32x4;
-    let xof_len = 12345u16;
-    let xof_core = Blake2xsCore::new(xof_len);
-
-    // Manually construct the CORRECT parameter block for a Blake2s XOF root hash
-    let mut p = [0u32; 8];
-    let digest_length = 32u32;
-    let key_length = 0u32;
-    let fanout = 1u32;
-    let depth = 1u32;
-
-    // p[0]: fanout, depth, key_length, digest_length
-    p[0] = digest_length | (key_length << 8) | (fanout << 16) | (depth << 24);
-    // p[1]: leaf_length (0 for root)
-    p[1] = 0;
-    // p[2]: node_offset low (0 for root)
-    p[2] = 0;
-    // p[3]: xof_digest_length
-    p[3] = xof_len as u32;
-    // p[4..7] are 0 for no salt/persona
-
-    // Calculate the expected initial state h = IV ^ p
-    let h = [
-        u32x4::new(0x6A09E667, 0xBB67AE85, 0x3C6EF372, 0xA54FF53A)
-            ^ u32x4::new(p[0], p[1], p[2], p[3]),
-        u32x4::new(0x510E527F, 0x9B05688C, 0x1F83D9AB, 0x5BE0CD19)
-            ^ u32x4::new(p[4], p[5], p[6], p[7]),
-    ];
-
-    assert_eq!(
-        xof_core.root_hasher.h[0], h[0],
-        "Blake2Xs XOF root hasher state (h[0]) does not match manual IV^p block."
-    );
-    assert_eq!(
-        xof_core.root_hasher.h[1], h[1],
-        "Blake2Xs XOF root hasher state (h[1]) does not match manual IV^p block."
-    );
-}
-
-#[test]
-fn blake2b_xof_parameter_placement() {
-    use blake2::Blake2xbCore;
-    use blake2::simd::u64x4;
-    let xof_len = 54321u32;
-    let xof_core = Blake2xbCore::new(xof_len);
-
-    // Manually construct parameter block as in the XOF root
-    let mut p = [0u64; 8];
-    let digest_length = 64u64;
-    let key_length = 0u64;
-    let fanout = 1u64;
-    let depth = 1u64;
-    p[0] = digest_length | (key_length << 8) | (fanout << 16) | (depth << 24);
-    p[1] = (xof_len as u64) << 32;
-    // All other fields zeroed
-    let h = [
-        u64x4::new(p[0], p[1], p[2], p[3]),
-        u64x4::new(p[4], p[5], p[6], p[7]),
-    ];
-
-    // IV for Blake2b
-    let iv = [
-        u64x4::new(
-            0x6A09E667F3BCC908,
-            0xBB67AE8584CAA73B,
-            0x3C6EF372FE94F82B,
-            0xA54FF53A5F1D36F1,
-        ),
-        u64x4::new(
-            0x510E527FADE682D1,
-            0x9B05688C2B3E6C1F,
-            0x1F83D9ABFB41BD6B,
-            0x5BE0CD19137E2179,
-        ),
-    ];
-    let expected = [iv[0] ^ h[0], iv[1] ^ h[1]];
-
-    assert_eq!(
-        xof_core.root_hasher.h, expected,
-        "Blake2Xb XOF root hasher state does not match manual IV^p block."
-    );
-}
-
-#[test]
-fn xof_state_differs_from_standard() {
-    use blake2::{Blake2sVarCore, Blake2xsCore};
-    let xof_len = 100u16;
-    let xof_core = Blake2xsCore::new(xof_len);
-    let standard_core = Blake2sVarCore::new(32).unwrap();
-
-    assert_ne!(
-        xof_core.root_hasher.h, standard_core.h,
-        "Blake2Xs XOF root state should differ from standard Blake2s state."
-    );
-}
+// Note: Tests for internal state verification have been removed as they access private fields.
+// The functionality is tested through public API tests that verify correct behavior.
 
 // ==== Keyed Hashing Tests ====