Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature request] Can we reference the RxRealm.xcframework in Package.swift? #160

Open
ian4hu opened this issue Jan 25, 2021 · 1 comment

Comments

@ian4hu
Copy link

ian4hu commented Jan 25, 2021

Package.swift can reference the xcframework as github release, so that we could use the xcframework in user project. Should we support it?

add targest like

// swift-tools-version:5.3
import PackageDescription
let package = Package(
    // ...
    targets: [
        .binaryTarget(
            name: "RxRealm", 
            url: "https://github.com/RxSwiftCommunity/RxRealm/releases/download/v5.0.1/RxRealm.xcframework.zip")
    ])
@JoeMatt
Copy link
Contributor

JoeMatt commented Jan 22, 2022

I generally think using binary targets goes against the point of a package source control system.

While it's great it it's supported by accident, is there a valid reason to put dev resources to ensuring this works over just using the source code?

@JoeMatt JoeMatt changed the title Can we reference the RxRealm.xcframework in Package.swift? [feature request] Can we reference the RxRealm.xcframework in Package.swift? Jan 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants