Skip to content

Commit 21d24a4

Browse files
committed
Update RxSwift for Carthage and share non-iOS schemes as well
1 parent 30aac4e commit 21d24a4

File tree

16 files changed

+395
-48
lines changed

16 files changed

+395
-48
lines changed

CHANGELOG.md

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,15 @@ All notable changes to this project will be documented in this file.
33

44
---
55

6-
## [master](https://github.com/RxSwiftCommunity/RxSwiftUtilities/tree/master) (Xcode 8 / Swift 3.0 compatible)
6+
## [master](https://github.com/RxSwiftCommunity/RxSwiftUtilities/tree/master) (Xcode 9 / Swift 4 compatible)
77

8-
*nothing*
8+
* nothing *
9+
10+
## [2.0.1](https://github.com/RxSwiftCommunity/RxSwiftUtilities/releases/tag/2.0.1) (Xcode 9 / Swift 4 compatible)
11+
12+
* Update to Swift 4
13+
* Update to RxSwift 4
14+
15+
## [1.0.1](https://github.com/RxSwiftCommunity/RxSwiftUtilities/releases/tag/1.0.1) (Xcode 8 / Swift 3 compatible)
16+
17+
* Initial project with ActivityIndicator

Cartfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
github "ReactiveX/RxSwift" ~> 3.0
1+
github "ReactiveX/RxSwift" ~> 4.0

Cartfile.resolved

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
github "ReactiveX/RxSwift" "3.0.1"
1+
github "ReactiveX/RxSwift" "4.1.2"

ExampleApp/ExampleApp.xcodeproj/project.pbxproj

Lines changed: 15 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -121,7 +121,7 @@
121121
isa = PBXProject;
122122
attributes = {
123123
LastSwiftUpdateCheck = 0800;
124-
LastUpgradeCheck = 0800;
124+
LastUpgradeCheck = 0920;
125125
ORGANIZATIONNAME = RxSwiftCommunity;
126126
TargetAttributes = {
127127
888CC1F81DE494BB00DAE48A = {
@@ -262,15 +262,22 @@
262262
CLANG_CXX_LIBRARY = "libc++";
263263
CLANG_ENABLE_MODULES = YES;
264264
CLANG_ENABLE_OBJC_ARC = YES;
265+
CLANG_WARN_BLOCK_CAPTURE_AUTORELEASING = YES;
265266
CLANG_WARN_BOOL_CONVERSION = YES;
267+
CLANG_WARN_COMMA = YES;
266268
CLANG_WARN_CONSTANT_CONVERSION = YES;
267269
CLANG_WARN_DIRECT_OBJC_ISA_USAGE = YES_ERROR;
268270
CLANG_WARN_DOCUMENTATION_COMMENTS = YES;
269271
CLANG_WARN_EMPTY_BODY = YES;
270272
CLANG_WARN_ENUM_CONVERSION = YES;
271273
CLANG_WARN_INFINITE_RECURSION = YES;
272274
CLANG_WARN_INT_CONVERSION = YES;
275+
CLANG_WARN_NON_LITERAL_NULL_CONVERSION = YES;
276+
CLANG_WARN_OBJC_LITERAL_CONVERSION = YES;
273277
CLANG_WARN_OBJC_ROOT_CLASS = YES_ERROR;
278+
CLANG_WARN_RANGE_LOOP_ANALYSIS = YES;
279+
CLANG_WARN_STRICT_PROTOTYPES = YES;
280+
CLANG_WARN_SUSPICIOUS_MOVE = YES;
274281
CLANG_WARN_SUSPICIOUS_MOVES = YES;
275282
CLANG_WARN_UNREACHABLE_CODE = YES;
276283
CLANG_WARN__DUPLICATE_METHOD_MATCH = YES;
@@ -311,15 +318,22 @@
311318
CLANG_CXX_LIBRARY = "libc++";
312319
CLANG_ENABLE_MODULES = YES;
313320
CLANG_ENABLE_OBJC_ARC = YES;
321+
CLANG_WARN_BLOCK_CAPTURE_AUTORELEASING = YES;
314322
CLANG_WARN_BOOL_CONVERSION = YES;
323+
CLANG_WARN_COMMA = YES;
315324
CLANG_WARN_CONSTANT_CONVERSION = YES;
316325
CLANG_WARN_DIRECT_OBJC_ISA_USAGE = YES_ERROR;
317326
CLANG_WARN_DOCUMENTATION_COMMENTS = YES;
318327
CLANG_WARN_EMPTY_BODY = YES;
319328
CLANG_WARN_ENUM_CONVERSION = YES;
320329
CLANG_WARN_INFINITE_RECURSION = YES;
321330
CLANG_WARN_INT_CONVERSION = YES;
331+
CLANG_WARN_NON_LITERAL_NULL_CONVERSION = YES;
332+
CLANG_WARN_OBJC_LITERAL_CONVERSION = YES;
322333
CLANG_WARN_OBJC_ROOT_CLASS = YES_ERROR;
334+
CLANG_WARN_RANGE_LOOP_ANALYSIS = YES;
335+
CLANG_WARN_STRICT_PROTOTYPES = YES;
336+
CLANG_WARN_SUSPICIOUS_MOVE = YES;
323337
CLANG_WARN_SUSPICIOUS_MOVES = YES;
324338
CLANG_WARN_UNREACHABLE_CODE = YES;
325339
CLANG_WARN__DUPLICATE_METHOD_MATCH = YES;

ExampleApp/ExampleApp/ActivityIndicatorViewController.swift

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -30,24 +30,24 @@ class ActivityIndicatorViewController: UITableViewController {
3030
[switch1, switch2, switch3].forEach { switchControl in
3131
createActivityObservable(switchControl: switchControl, activityIndicator: activityIndicator)
3232
.subscribe()
33-
.addDisposableTo(disposeBag)
33+
.disposed(by: disposeBag)
3434
}
3535

3636
// This will drive the UILabel in the view controller
3737
activityIndicator.asDriver()
3838
.map { String(describing: $0) }
3939
.drive(valueCell.textLabel!.rx.text)
40-
.addDisposableTo(disposeBag)
40+
.disposed(by: disposeBag)
4141

4242
// This will drive a UIActivityIndicatorView in the view controller
4343
activityIndicator.asDriver()
4444
.drive(activityIndicatorView.rx.isAnimating)
45-
.addDisposableTo(disposeBag)
45+
.disposed(by: disposeBag)
4646

4747
// This will drive the Network Activity Indicator in the status bar
4848
activityIndicator.asDriver()
4949
.drive(UIApplication.shared.rx.isNetworkActivityIndicatorVisible)
50-
.addDisposableTo(disposeBag)
50+
.disposed(by: disposeBag)
5151
}
5252

5353
private func createActivityObservable(switchControl: UISwitch,

ExampleApp/ExampleApp/Base.lproj/Main.storyboard

Lines changed: 31 additions & 17 deletions
Large diffs are not rendered by default.

ExampleApp/Podfile

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
source 'https://github.com/CocoaPods/Specs.git'
2+
platform :ios, '10.0'
13
use_frameworks!
24

35
target "ExampleApp" do

ExampleApp/Podfile.lock

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,6 @@ SPEC CHECKSUMS:
1818
RxSwift: e49536837d9901277638493ea537394d4b55f570
1919
RxSwiftUtilities: b292dcdc286744db591fea3146c9382abc6e0033
2020

21-
PODFILE CHECKSUM: 7684ee7ca38232e18d184c27a385894b625d7ee4
21+
PODFILE CHECKSUM: 76bf4791be77375ab3f65b32b122237d1e9eaf79
2222

2323
COCOAPODS: 1.4.0

README.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ let signedIn = loginButtonTap.withLatestFrom(usernameAndPassword)
2828

2929
signingIn.asDriver()
3030
.drive(UIApplication.shared.rx.isNetworkActivityIndicatorVisible)
31-
.addDisposableTo(disposeBag)
31+
.disposed(by: disposeBag)
3232
```
3333

3434
## Example App
@@ -46,8 +46,8 @@ Open the project located in [`ExampleApp/`](ExampleApp/) with Xcode and build/ru
4646

4747
## Requirements
4848

49-
* Xcode 8.0
50-
* Swift 3.0
49+
* Xcode 9
50+
* Swift 4
5151

5252
## Installation
5353

RxSwiftUtilities.podspec

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,14 @@
11
Pod::Spec.new do |s|
22
s.name = "RxSwiftUtilities"
3-
s.version = "2.0.0"
3+
s.version = "2.0.1"
44
s.summary = "Helpful classes and extensions for RxSwift"
55
s.description = <<-DESC
66
Helpful classes and extensions for RxSwift which don't belong in RxSwift core.
77
DESC
88
s.homepage = "https://github.com/RxSwiftCommunity/RxSwiftUtilities"
99
s.license = { :type => "MIT", :file => "LICENSE.md" }
1010
s.author = { "Jesse Farless" => "[email protected]" }
11+
s.swift_version = "4.0"
1112
s.ios.deployment_target = "8.0"
1213
s.osx.deployment_target = "10.10"
1314
s.tvos.deployment_target = "9.0"

0 commit comments

Comments
 (0)