Skip to content

Commit 5004c17

Browse files
authored
Merge pull request #23 from farshadtx/master
- Add Github Action - Update PodSpec - Update Sample to Swift 5
2 parents a3e91fb + 56e22fe commit 5004c17

File tree

9 files changed

+72
-38
lines changed

9 files changed

+72
-38
lines changed

.github/workflows/action.yml

Lines changed: 32 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,32 @@
1+
name: CI
2+
3+
on:
4+
push:
5+
branches:
6+
- master
7+
pull_request:
8+
branches:
9+
- master
10+
11+
jobs:
12+
tests:
13+
runs-on: macos-10.15
14+
15+
steps:
16+
- uses: actions/checkout@v2
17+
18+
- uses: actions/cache@v2
19+
with:
20+
path: Carthage
21+
key: ${{ runner.os }}-carthage-${{ hashFiles('**/Cartfile.resolved') }}
22+
restore-keys: |
23+
${{ runner.os }}-carthage-
24+
25+
- name: Carthage Bootstrap
26+
run: carthage bootstrap --cache-builds --no-use-binaries --platform ios
27+
28+
- name: Run all tests
29+
run: xcodebuild clean build test -scheme 'RxSwiftUtilities iOS' -destination "platform=iOS Simulator,name=iPhone 11" -enableCodeCoverage YES
30+
31+
- name: CodeCov
32+
run: bash <(curl -s https://codecov.io/bash) -J 'RxSwiftUtilities'

.travis.yml

Lines changed: 0 additions & 7 deletions
This file was deleted.

CHANGELOG.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,12 @@ All notable changes to this project will be documented in this file.
77

88
* nothing *
99

10+
## [2.2.0](https://github.com/RxSwiftCommunity/RxSwiftUtilities/releases/tag/2.2.0) (Swift 5 compatible)
11+
12+
* Add Github Action
13+
* Update to Swift 5
14+
* Update PodSpec
15+
1016
## [2.1.0](https://github.com/RxSwiftCommunity/RxSwiftUtilities/releases/tag/2.1.0) (Xcode 10 / Swift 4.2 compatible)
1117

1218
* Add two-way binding operator `<->`

Cartfile.resolved

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
github "ReactiveX/RxSwift" "5.0.1"
1+
github "ReactiveX/RxSwift" "5.1.1"

ExampleApp/ExampleApp.xcodeproj/project.pbxproj

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -123,20 +123,20 @@
123123
isa = PBXProject;
124124
attributes = {
125125
LastSwiftUpdateCheck = 0800;
126-
LastUpgradeCheck = 1000;
126+
LastUpgradeCheck = 1150;
127127
ORGANIZATIONNAME = RxSwiftCommunity;
128128
TargetAttributes = {
129129
888CC1F81DE494BB00DAE48A = {
130130
CreatedOnToolsVersion = 8.0;
131131
DevelopmentTeam = 3V4RS4ALV7;
132-
LastSwiftMigration = 1000;
132+
LastSwiftMigration = 1150;
133133
ProvisioningStyle = Automatic;
134134
};
135135
};
136136
};
137137
buildConfigurationList = 888CC1F41DE494BB00DAE48A /* Build configuration list for PBXProject "ExampleApp" */;
138138
compatibilityVersion = "Xcode 3.2";
139-
developmentRegion = English;
139+
developmentRegion = en;
140140
hasScannedForEncodings = 0;
141141
knownRegions = (
142142
en,
@@ -173,15 +173,15 @@
173173
);
174174
inputPaths = (
175175
"${PODS_ROOT}/Target Support Files/Pods-ExampleApp/Pods-ExampleApp-frameworks.sh",
176-
"${BUILT_PRODUCTS_DIR}/RxAtomic/RxAtomic.framework",
177176
"${BUILT_PRODUCTS_DIR}/RxCocoa/RxCocoa.framework",
177+
"${BUILT_PRODUCTS_DIR}/RxRelay/RxRelay.framework",
178178
"${BUILT_PRODUCTS_DIR}/RxSwift/RxSwift.framework",
179179
"${BUILT_PRODUCTS_DIR}/RxSwiftUtilities/RxSwiftUtilities.framework",
180180
);
181181
name = "[CP] Embed Pods Frameworks";
182182
outputPaths = (
183-
"${TARGET_BUILD_DIR}/${FRAMEWORKS_FOLDER_PATH}/RxAtomic.framework",
184183
"${TARGET_BUILD_DIR}/${FRAMEWORKS_FOLDER_PATH}/RxCocoa.framework",
184+
"${TARGET_BUILD_DIR}/${FRAMEWORKS_FOLDER_PATH}/RxRelay.framework",
185185
"${TARGET_BUILD_DIR}/${FRAMEWORKS_FOLDER_PATH}/RxSwift.framework",
186186
"${TARGET_BUILD_DIR}/${FRAMEWORKS_FOLDER_PATH}/RxSwiftUtilities.framework",
187187
);
@@ -248,6 +248,7 @@
248248
isa = XCBuildConfiguration;
249249
buildSettings = {
250250
ALWAYS_SEARCH_USER_PATHS = NO;
251+
CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED = YES;
251252
CLANG_ANALYZER_NONNULL = YES;
252253
CLANG_CXX_LANGUAGE_STANDARD = "gnu++0x";
253254
CLANG_CXX_LIBRARY = "libc++";
@@ -306,6 +307,7 @@
306307
isa = XCBuildConfiguration;
307308
buildSettings = {
308309
ALWAYS_SEARCH_USER_PATHS = NO;
310+
CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED = YES;
309311
CLANG_ANALYZER_NONNULL = YES;
310312
CLANG_CXX_LANGUAGE_STANDARD = "gnu++0x";
311313
CLANG_CXX_LIBRARY = "libc++";
@@ -363,7 +365,7 @@
363365
LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/Frameworks";
364366
PRODUCT_BUNDLE_IDENTIFIER = com.RxSwiftCommunity.ExampleApp;
365367
PRODUCT_NAME = "$(TARGET_NAME)";
366-
SWIFT_VERSION = 4.2;
368+
SWIFT_VERSION = 5.0;
367369
};
368370
name = Debug;
369371
};
@@ -377,7 +379,7 @@
377379
LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/Frameworks";
378380
PRODUCT_BUNDLE_IDENTIFIER = com.RxSwiftCommunity.ExampleApp;
379381
PRODUCT_NAME = "$(TARGET_NAME)";
380-
SWIFT_VERSION = 4.2;
382+
SWIFT_VERSION = 5.0;
381383
};
382384
name = Release;
383385
};

ExampleApp/ExampleApp/TwoWayBindingViewController.swift

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ class TwoWayBindingViewController: UITableViewController, UITextFieldDelegate {
1717
@IBOutlet private weak var label: UILabel!
1818
@IBOutlet private weak var stackView: UIStackView!
1919

20-
private let variable = Variable<String?>(nil)
20+
private let behaviorRelay = BehaviorRelay<String?>(value: nil)
2121
private let disposeBag = DisposeBag()
2222

2323
override func viewDidLoad() {
@@ -40,10 +40,10 @@ class TwoWayBindingViewController: UITableViewController, UITextFieldDelegate {
4040
})
4141
.disposed(by: disposeBag)
4242

43-
(textField.rx.text <-> variable)
43+
(textField.rx.text <-> behaviorRelay)
4444
.disposed(by: disposeBag)
4545

46-
variable
46+
behaviorRelay
4747
.asDriver()
4848
.drive(label.rx.text)
4949
.disposed(by: disposeBag)
@@ -57,7 +57,7 @@ class TwoWayBindingViewController: UITableViewController, UITextFieldDelegate {
5757
button.rx.tap
5858
.asDriver()
5959
.map { button.titleLabel?.text }
60-
.drive(variable)
60+
.drive(behaviorRelay)
6161
.disposed(by: disposeBag)
6262
button.backgroundColor = UIColor(displayP3Red: 0.93, green: 0.93, blue: 0.93, alpha: 1)
6363
button.layer.cornerRadius = 4

ExampleApp/Podfile.lock

Lines changed: 16 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -1,32 +1,33 @@
11
PODS:
2-
- RxAtomic (4.4.0)
3-
- RxCocoa (4.4.0):
4-
- RxSwift (~> 4.0)
5-
- RxSwift (4.4.0):
6-
- RxAtomic (~> 4.4)
7-
- RxSwiftUtilities (2.1.0):
8-
- RxCocoa (~> 4.4)
9-
- RxSwift (~> 4.4)
2+
- RxCocoa (5.1.1):
3+
- RxRelay (~> 5)
4+
- RxSwift (~> 5)
5+
- RxRelay (5.1.1):
6+
- RxSwift (~> 5)
7+
- RxSwift (5.1.1)
8+
- RxSwiftUtilities (2.2.0):
9+
- RxCocoa (~> 5.1)
10+
- RxSwift (~> 5.1)
1011

1112
DEPENDENCIES:
1213
- RxSwiftUtilities (from `../`)
1314

1415
SPEC REPOS:
15-
https://github.com/cocoapods/specs.git:
16-
- RxAtomic
16+
https://github.com/CocoaPods/Specs.git:
1717
- RxCocoa
18+
- RxRelay
1819
- RxSwift
1920

2021
EXTERNAL SOURCES:
2122
RxSwiftUtilities:
2223
:path: "../"
2324

2425
SPEC CHECKSUMS:
25-
RxAtomic: eacf60db868c96bfd63320e28619fe29c179656f
26-
RxCocoa: df63ebf7b9a70d6b4eeea407ed5dd4efc8979749
27-
RxSwift: 5976ecd04fc2fefd648827c23de5e11157faa973
28-
RxSwiftUtilities: 01034c5ba9ea6b3910458b46f60eff9eb66103f9
26+
RxCocoa: 32065309a38d29b5b0db858819b5bf9ef038b601
27+
RxRelay: d77f7d771495f43c556cbc43eebd1bb54d01e8e9
28+
RxSwift: 81470a2074fa8780320ea5fe4102807cb7118178
29+
RxSwiftUtilities: 891ab1aefae2d3d5669ed6281efd1da20ae31ff6
2930

3031
PODFILE CHECKSUM: 76bf4791be77375ab3f65b32b122237d1e9eaf79
3132

32-
COCOAPODS: 1.6.0.beta.1
33+
COCOAPODS: 1.8.4

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ RxSwiftUtilities
33
[![CocoaPods Compatible](https://img.shields.io/cocoapods/v/RxSwiftUtilities.svg)](https://cocoapods.org/pods/RxSwiftUtilities)
44
[![Carthage Compatible](https://img.shields.io/badge/Carthage-compatible-4BC51D.svg?style=flat)](https://github.com/Carthage/Carthage)
55
[![Platform](https://img.shields.io/cocoapods/p/RxSwiftUtilities.svg?style=flat)](http://cocoadocs.org/docsets/RxSwiftUtilities)
6-
[![Build Status](https://travis-ci.org/RxSwiftCommunity/RxSwiftUtilities.svg?branch=master)](https://travis-ci.org/RxSwiftCommunity/RxSwiftUtilities)
6+
![CI](https://github.com/RxSwiftCommunity/RxSwiftUtilities/workflows/CI/badge.svg?branch=master)
77
[![codecov](https://codecov.io/gh/RxSwiftCommunity/RxSwiftUtilities/branch/master/graph/badge.svg)](https://codecov.io/gh/RxSwiftCommunity/RxSwiftUtilities)
88

99
## About

RxSwiftUtilities.podspec

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
Pod::Spec.new do |s|
22
s.name = "RxSwiftUtilities"
3-
s.version = "2.1.0"
3+
s.version = "2.2.0"
44
s.summary = "Helpful classes and extensions for RxSwift"
55
s.description = <<-DESC
66
Helpful classes and extensions for RxSwift which don't belong in RxSwift core.
@@ -16,6 +16,6 @@ Helpful classes and extensions for RxSwift which don't belong in RxSwift core.
1616
s.source = { :git => "https://github.com/RxSwiftCommunity/RxSwiftUtilities.git", :tag => "#{s.version}" }
1717
s.source_files = 'Source/Common/*.swift'
1818
s.ios.source_files = 'Source/iOS/*.swift'
19-
s.dependency "RxSwift", "~> 5.0"
20-
s.dependency "RxCocoa", "~> 5.0"
19+
s.dependency "RxSwift", "~> 5.1"
20+
s.dependency "RxCocoa", "~> 5.1"
2121
end

0 commit comments

Comments
 (0)