Skip to content

Commit 6193f55

Browse files
committed
Add warning about the use of fingerprint on signature verification method
1 parent 556e279 commit 6193f55

File tree

2 files changed

+7
-2
lines changed

2 files changed

+7
-2
lines changed

README.md

+3-1
Original file line numberDiff line numberDiff line change
@@ -135,6 +135,7 @@ In production, the `strict` parameter **MUST** be set as `"true"` and the
135135
something other than SHA1 (see https://shattered.io/ ). Otherwise your
136136
environment is not secure and will be exposed to attacks.
137137

138+
In production also we highly recommended to register on the settings the IdP certificate instead of using the fingerprint method. The fingerprint, is a hash, so at the end is open to a collision attack that can end on a siganture validation bypass. Other SAML toolkits deprecated that mechanism, we maintain it for compatibility and also to be used on test environment.
138139

139140
Getting started
140141
---------------
@@ -345,7 +346,8 @@ $settings = array (
345346
'x509cert' => '',
346347
/*
347348
* Instead of use the whole x509cert you can use a fingerprint in order to
348-
* validate a SAMLResponse.
349+
* validate a SAMLResponse, but we don't recommend to use that
350+
* method on production since is exploitable by a collision attack.
349351
* (openssl x509 -noout -fingerprint -in "idp.crt" to generate it,
350352
* or add for example the -sha256 , -sha384 or -sha512 parameter)
351353
*

settings_example.php

+4-1
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,10 @@
101101
// Public x509 certificate of the IdP
102102
'x509cert' => '',
103103
/*
104-
* Instead of use the whole x509cert you can use a fingerprint
104+
* Instead of use the whole x509cert you can use a fingerprint in
105+
* order to validate the SAMLResponse, but we don't recommend to use
106+
* that method on production since is exploitable by a collision
107+
* attack.
105108
* (openssl x509 -noout -fingerprint -in "idp.crt" to generate it,
106109
* or add for example the -sha256 , -sha384 or -sha512 parameter)
107110
*

0 commit comments

Comments
 (0)