Skip to content

Commit c889f6b

Browse files
committed
Fix mispelings. See #592
1 parent 8fec41d commit c889f6b

23 files changed

+100
-102
lines changed

CHANGELOG

+7-7
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ v3.5.0
3434
* [#433](https://github.com/onelogin/php-saml/issues/443) Fix Incorrect Destination in LogoutResponse when using responseUrl #443
3535
* Update xmlseclibs to 3.1.1
3636
* Add support for SMARTCARD_PKI and RSA_TOKEN Auth Contexts
37-
* Get lib path dinamically
37+
* Get lib path dynamically
3838
* Check for x509Cert of the IdP when loading settings, even if the security index was not provided
3939
* Support Statements with Attribute elements with the same name enabling the allowRepeatAttributeName setting
4040

@@ -57,7 +57,7 @@ v.3.3.1
5757

5858
v.3.3.0
5959
* Set true as the default value for strict setting
60-
* Relax comparision of false on SignMetadata
60+
* Relax comparison of false on SignMetadata
6161
* Fix CI
6262

6363
v.3.2.1
@@ -139,7 +139,7 @@ v.2.12.0
139139
* [#263](https://github.com/onelogin/php-saml/issues/263) Fix incompatibility with ADFS on SLO. When on php saml settings NameID Format is set as unspecified but the SAMLResponse has no NameID Format, no NameID Format should be specified on LogoutRequest.
140140

141141
v.2.11.0
142-
* [#236](https://github.com/onelogin/php-saml/pull/236) Exclude unnecesary files from Composer production downloads
142+
* [#236](https://github.com/onelogin/php-saml/pull/236) Exclude unnecessary files from Composer production downloads
143143
* [#226](https://github.com/onelogin/php-saml/pull/226) Add possibility to handle nameId NameQualifier attribute in SLO Request
144144
* Improve logout documentation on Readme.
145145
* Improve multi-certificate support
@@ -252,7 +252,7 @@ v.2.6.1
252252
-------
253253
* Fix bug on cacheDuration of the Metadata XML generated.
254254
* Make SPNameQualifier optional on the generateNameId method. Avoid the use of SPNameQualifier when generating the NameID on the LogoutRequest builder.
255-
* Allows the authn comparsion attribute to be set via config.
255+
* Allows the authn comparison attribute to be set via config.
256256
* Retrieve Session Timeout after processResponse with getSessionExpiration().
257257
* Improve readme readability.
258258
* Allow single log out to work for applications not leveraging php session_start. Added a callback parameter in order to close the session at processSLO.
@@ -270,8 +270,8 @@ v.2.6.0
270270

271271
v.2.5.0
272272
-------
273-
* Do accesible the ID of the object Logout Request (id attribute).
274-
* Add note about the fact that PHP 5.3 is unssuported.
273+
* Do accessible the ID of the object Logout Request (id attribute).
274+
* Add note about the fact that PHP 5.3 is unsupported.
275275
* Add fingerprint algorithm support.
276276
* Add dependences to composer.
277277

@@ -299,7 +299,7 @@ v.2.2.0
299299
-------
300300
* Fix bug with Encrypted nameID on LogoutRequest.
301301
* Fixed usability bug. SP will inform about AuthFail status after process a Response.
302-
* Added SessionIndex support on LogoutRequest, and know is accesible from the Auth class.
302+
* Added SessionIndex support on LogoutRequest, and know is accessible from the Auth class.
303303
* LogoutRequest and LogoutResponse classes now accept non deflated xml.
304304
* Improved the XML metadata/ Decrypted Assertion output. (prettyprint).
305305
* Fix bug in formatPrivateKey method, the key could be not RSA.

README.md

+10-10
Original file line numberDiff line numberDiff line change
@@ -164,14 +164,14 @@ a trusted and expected URL.
164164
Read more about Open Redirect [CWE-601](https://cwe.mitre.org/data/definitions/601.html).
165165

166166

167-
### Avoiding Reply attacks ###
167+
### Avoiding Replay attacks ###
168168

169-
A reply attack is basically try to reuse an intercepted valid SAML Message in order to impersonate a SAML action (SSO or SLO).
169+
A replay attack is basically try to reuse an intercepted valid SAML Message in order to impersonate a SAML action (SSO or SLO).
170170

171171
SAML Messages have a limited timelife (NotBefore, NotOnOrAfter) that
172172
make harder this kind of attacks, but they are still possible.
173173

174-
In order to avoid them, the SP can keep a list of SAML Messages or Assertion IDs alredy valdidated and processed. Those values only need
174+
In order to avoid them, the SP can keep a list of SAML Messages or Assertion IDs alredy validated and processed. Those values only need
175175
to be stored the amount of time of the SAML Message life time, so
176176
we don't need to store all processed message/assertion Ids, but the most recent ones.
177177

@@ -511,15 +511,15 @@ $advancedSettings = array(
511511

512512
// If true, Destination URL should strictly match to the address to
513513
// which the response has been sent.
514-
// Notice that if 'relaxDestinationValidation' is true an empty Destintation
514+
// Notice that if 'relaxDestinationValidation' is true an empty Destination
515515
// will be accepted.
516516
'destinationStrictlyMatches' => false,
517517

518518
// If true, the toolkit will not raised an error when the Statement Element
519519
// contain atribute elements with name duplicated
520520
'allowRepeatAttributeName' => false,
521521

522-
// If true, SAMLResponses with an InResponseTo value will be rejectd if not
522+
// If true, SAMLResponses with an InResponseTo value will be rejected if not
523523
// AuthNRequest ID provided to the validation method.
524524
'rejectUnsolicitedResponsesWithInResponseTo' => false,
525525

@@ -913,7 +913,7 @@ $auth->processSLO(false, $requestID);
913913
$errors = $auth->getErrors();
914914

915915
if (empty($errors)) {
916-
echo 'Sucessfully logged out';
916+
echo 'Successfully logged out';
917917
} else {
918918
echo implode(', ', $errors);
919919
}
@@ -1120,7 +1120,7 @@ if (isset($_GET['sso'])) { // SSO action. Will send an AuthNRequest to the I
11201120
echo '<p>' . implode(', ', $errors) . '</p>';
11211121
}
11221122
// This check if the response was
1123-
if (!$auth->isAuthenticated()) { // sucessfully validated and the user
1123+
if (!$auth->isAuthenticated()) { // successfully validated and the user
11241124
echo '<p>Not authenticated</p>'; // data retrieved or not
11251125
exit();
11261126
}
@@ -1135,7 +1135,7 @@ if (isset($_GET['sso'])) { // SSO action. Will send an AuthNRequest to the I
11351135
$auth->processSLO(); // Process the Logout Request & Logout Response
11361136
$errors = $auth->getErrors(); // Retrieves possible validation errors
11371137
if (empty($errors)) {
1138-
echo '<p>Sucessfully logged out</p>';
1138+
echo '<p>Successfully logged out</p>';
11391139
} else {
11401140
echo '<p>' . implode(', ', $errors) . '</p>';
11411141
}
@@ -1303,7 +1303,7 @@ SAML 2 Authentication Response class
13031303
SAML 2 Logout Request class
13041304

13051305
* `LogoutRequest` - Constructs the Logout Request object.
1306-
* `getRequest` - Returns the Logout Request defated, base64encoded, unsigned
1306+
* `getRequest` - Returns the Logout Request deflated, base64encoded, unsigned
13071307
* `getID` - Returns the ID of the Logout Request. (If you have the object you can access to the id attribute)
13081308
* `getNameIdData` - Gets the NameID Data of the the Logout Request.
13091309
* `getNameId` - Gets the NameID of the Logout Request.
@@ -1370,7 +1370,7 @@ A class that contains functionality related to the metadata of the SP
13701370

13711371
* `builder` - Generates the metadata of the SP based on the settings.
13721372
* `signmetadata` - Signs the metadata with the key/cert provided
1373-
* `addX509KeyDescriptors` - Adds the x509 descriptors (sign/encriptation) to
1373+
* `addX509KeyDescriptors` - Adds the x509 descriptors (sign/encryption) to
13741374
the metadata
13751375

13761376
##### OneLogin\Saml2\Utils - `Utils.php` #####

advanced_settings_example.php

+4-4
Original file line numberDiff line numberDiff line change
@@ -87,15 +87,15 @@
8787

8888
// If true, Destination URL should strictly match to the address to
8989
// which the response has been sent.
90-
// Notice that if 'relaxDestinationValidation' is true an empty Destintation
90+
// Notice that if 'relaxDestinationValidation' is true an empty Destination
9191
// will be accepted.
9292
'destinationStrictlyMatches' => false,
9393

9494
// If true, the toolkit will not raised an error when the Statement Element
9595
// contain atribute elements with name duplicated
9696
'allowRepeatAttributeName' => false,
9797

98-
// If true, SAMLResponses with an InResponseTo value will be rejectd if not
98+
// If true, SAMLResponses with an InResponseTo value will be rejected if not
9999
// AuthNRequest ID provided to the validation method.
100100
'rejectUnsolicitedResponsesWithInResponseTo' => false,
101101

@@ -132,7 +132,7 @@
132132
'lowercaseUrlencoding' => false,
133133
),
134134

135-
// Contact information template, it is recommended to suply a technical and support contacts
135+
// Contact information template, it is recommended to supply a technical and support contacts
136136
'contactPerson' => array(
137137
'technical' => array(
138138
'givenName' => '',
@@ -144,7 +144,7 @@
144144
),
145145
),
146146

147-
// Organization information template, the info in en_US lang is recomended, add more if required
147+
// Organization information template, the info in en_US lang is recommended, add more if required
148148
'organization' => array(
149149
'en-US' => array(
150150
'name' => '',

demo1/Readme.txt

+2-2
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ How it works
4545
process, the index.php view.
4646

4747
2.2 in the second link we access to (attrs.php) have the same process
48-
described at 2.1 with the diference that as RelayState is set the attrs.php
48+
described at 2.1 with the difference that as RelayState is set the attrs.php
4949

5050
3. The SAML Response is processed in the ACS (index.php?acs), if the Response
5151
is not valid, the process stop here and a message is showed. Otherwise we
@@ -68,7 +68,7 @@ How it works
6868
Request to the SP (SLS endpoint, index.php?sls). The SLS endpoint of the SP
6969
process the Logout Request and if is valid, close the session of the user
7070
at the local app and send a Logout Response to the IdP (to the SLS endpoint
71-
of the IdP). The IdP recieve the Logout Response, process it and close the
71+
of the IdP). The IdP receive the Logout Response, process it and close the
7272
session at of the IdP. Notice that the SLO Workflow starts and ends at the IdP.
7373

7474
Notice that all the SAML Requests and Responses are handler at a unique file,

demo1/index.php

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
<?php
2-
2+
33
/**
44
* SAML Handler
55
*/
@@ -110,7 +110,7 @@
110110
$auth->processSLO(false, $requestID);
111111
$errors = $auth->getErrors();
112112
if (empty($errors)) {
113-
echo '<p>Sucessfully logged out</p>';
113+
echo '<p>Successfully logged out</p>';
114114
} else {
115115
echo '<p>' . htmlentities(implode(', ', $errors)) . '</p>';
116116
if ($auth->getSettings()->isDebugActive()) {

demo2/Readme.txt

+2-4
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ demo1, only changes the targets.
5454
3. We are logged in the app and the user attributes are showed.
5555
At this point, we can test the single log out functionality.
5656

57-
4. The single log out funcionality could be tested by 2 ways.
57+
4. The single log out functionality could be tested by 2 ways.
5858

5959
4.1 SLO Initiated by SP. Click on the "logout" link at the SP, after that
6060
we are redirected to the slo.php view and there a Logout Request is sent
@@ -69,8 +69,6 @@ demo1, only changes the targets.
6969
Request to the SP (SLS endpoint sls.php of the endpoint folder).
7070
The SLS endpoint of the SP process the Logout Request and if is valid,
7171
close the session of the user at the local app and sends a Logout Response
72-
to the IdP (to the SLS endpoint of the IdP).The IdP recieves the Logout
72+
to the IdP (to the SLS endpoint of the IdP).The IdP receives the Logout
7373
Response, process it and close the session at of the IdP. Notice that the
7474
SLO Workflow starts and ends at the IdP.
75-
76-

endpoints/sls.php

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
<?php
2-
2+
33
/**
44
* SP Single Logout Service Endpoint
55
*/
@@ -17,7 +17,7 @@
1717
$errors = $auth->getErrors();
1818

1919
if (empty($errors)) {
20-
echo 'Sucessfully logged out';
20+
echo 'Successfully logged out';
2121
} else {
2222
echo htmlentities(implode(', ', $errors));
2323
}

src/Saml2/LogoutRequest.php

+1-1
Original file line numberDiff line numberDiff line change
@@ -155,7 +155,7 @@ public function __construct(\OneLogin\Saml2\Settings $settings, $request = null,
155155
}
156156

157157
/**
158-
* Returns the Logout Request defated, base64encoded, unsigned
158+
* Returns the Logout Request deflated, base64encoded, unsigned
159159
*
160160
* @param bool|null $deflate Whether or not we should 'gzdeflate' the request body before we return it.
161161
*

src/Saml2/LogoutResponse.php

+1-1
Original file line numberDiff line numberDiff line change
@@ -235,7 +235,7 @@ public function isValid($requestId = null, $retrieveParametersFromServer = false
235235
}
236236

237237
/**
238-
* Extracts a node from the DOMDocument (Logout Response Menssage)
238+
* Extracts a node from the DOMDocument (Logout Response Message)
239239
*
240240
* @param string $query Xpath Expression
241241
*

src/Saml2/Response.php

+5-5
Original file line numberDiff line numberDiff line change
@@ -245,7 +245,7 @@ public function isValid($requestId = null)
245245
);
246246
}
247247

248-
// Validate Asserion timestamps
248+
// Validate Assertion timestamps
249249
$this->validateTimestamps();
250250

251251
// Validate AuthnStatement element exists and is unique
@@ -1002,9 +1002,9 @@ public function validateSignedElements($signedElements)
10021002
$responseTag = '{'.Constants::NS_SAMLP.'}Response';
10031003
$assertionTag = '{'.Constants::NS_SAML.'}Assertion';
10041004

1005-
$ocurrence = array_count_values($signedElements);
1006-
if ((in_array($responseTag, $signedElements) && $ocurrence[$responseTag] > 1)
1007-
|| (in_array($assertionTag, $signedElements) && $ocurrence[$assertionTag] > 1)
1005+
$occurrence = array_count_values($signedElements);
1006+
if ((in_array($responseTag, $signedElements) && $occurrence[$responseTag] > 1)
1007+
|| (in_array($assertionTag, $signedElements) && $occurrence[$assertionTag] > 1)
10081008
|| !in_array($responseTag, $signedElements) && !in_array($assertionTag, $signedElements)
10091009
) {
10101010
return false;
@@ -1087,7 +1087,7 @@ protected function _queryAssertion($assertionXpath)
10871087
}
10881088

10891089
/**
1090-
* Extracts nodes that match the query from the DOMDocument (Response Menssage)
1090+
* Extracts nodes that match the query from the DOMDocument (Response Message)
10911091
*
10921092
* @param string $query Xpath Expression
10931093
*

src/Saml2/Settings.php

+3-3
Original file line numberDiff line numberDiff line change
@@ -661,7 +661,7 @@ public function checkSPSettings(array $settings)
661661
if (!isset($contact['givenName']) || empty($contact['givenName'])
662662
|| !isset($contact['emailAddress']) || empty($contact['emailAddress'])
663663
) {
664-
$errors[] = 'contact_not_enought_data';
664+
$errors[] = 'contact_not_enough_data';
665665
break;
666666
}
667667
}
@@ -673,7 +673,7 @@ public function checkSPSettings(array $settings)
673673
|| !isset($organization['displayname']) || empty($organization['displayname'])
674674
|| !isset($organization['url']) || empty($organization['url'])
675675
) {
676-
$errors[] = 'organization_not_enought_data';
676+
$errors[] = 'organization_not_enough_data';
677677
break;
678678
}
679679
}
@@ -1037,7 +1037,7 @@ public function formatIdPCert()
10371037
}
10381038

10391039
/**
1040-
* Formats the Multple IdP certs.
1040+
* Formats the Multiple IdP certs.
10411041
*/
10421042
public function formatIdPCertMulti()
10431043
{

0 commit comments

Comments
 (0)