Skip to content

SapMachine (25) #2088: Failure in VitalsValuesSanityCheck #2095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: sapmachine25
Choose a base branch
from
Open

SapMachine (25) #2088: Failure in VitalsValuesSanityCheck #2095

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions test/hotspot/jtreg/runtime/Vitals/VitalsValuesSanityCheck.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -319,8 +319,12 @@ public void run(CommandExecutor executor) {
// we should not see mlc > rss
if (jvm_nmt_mlc != -1) {
if (Platform.isDebugBuild()) {
if (proc_rss_all < jvm_nmt_mlc) {
throw new RuntimeException("NMT mlc higher than RSS?");
// Give a little slack for two reasons:
// - Not all allocated memory has to be in RSS, since some could be swapped out.
// - The peak RSS and peak malloc size are not taken at the exactly same time.
// Both should not lead to a large difference, so we allow a 25 percent deviation.
if (proc_rss_all * 1.25 <= jvm_nmt_mlc) {
throw new RuntimeException("NMT mlc more than 25 percent higher than RSS?");
}
}
}
Expand Down
Loading