Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polishing some Bookmark-related items #548

Open
gpeuc opened this issue Jul 28, 2023 · 3 comments
Open

Polishing some Bookmark-related items #548

gpeuc opened this issue Jul 28, 2023 · 3 comments
Assignees
Labels
bug-priority:medium Medium Priority Bug type:ux-design UX design needed

Comments

@gpeuc
Copy link
Contributor

gpeuc commented Jul 28, 2023

Hello everyone, @oliversberzs @carwelsh @theStiggySpd


Just a quick round of polish


Screenshot 2023-07-28 at 09 50 36

If there are no Bookmarks saved, then we should remove the Bookmarks label. It's pointless to have it, since it labels null content. If
there are some Bookmarks and last one is removed, then of course, we remove the label as well.


The construction of Bookmarks H3 is wrong, and it should follow how H3 of "Last Visited" is constructed. There should be a span around text, so we can manipulate where the text is, and not have a space in front of the word Bookmark to space it away from the icon. Just copy the Last Visited construction and change the icon, no need to reinvent the wheel here.

Screenshot 2023-07-28 at 09 55 29 Screenshot 2023-07-28 at 09 56 01
Screenshot 2023-07-28 at 09 52 59 Screenshot 2023-07-28 at 09 53 51

The star is too high, needs to go down 1-2px so it's better aligned with the text. Most likely when last point is implemented then this one will automatically happen.


We need more space above Bookmarks label, as at the moment it is closer to the top element (Last Visited line item) than to the actual bookmark block.

It should have margin-top:30px altogether, so it is moved down. At the moment it has 15 top and 15 bottom, so let's just double the top one.

Screenshot 2023-07-28 at 09 58 48
@gpeuc gpeuc added bug-priority:medium Medium Priority Bug type:ux-design UX design needed labels Jul 28, 2023
@oliversberzs oliversberzs self-assigned this Aug 7, 2023
@oliversberzs
Copy link
Contributor

@carwelsh @ritarora done & merged

@hitesh-parmar
Copy link
Contributor

If there are no Bookmarks saved, then we should remove the Bookmarks label. It's pointless to have it, since it labels null content. If
there are some Bookmarks and last one is removed, then of course, we remove the label as well.

Hi @gpeuc, Regarding point 1, wouldn't it be better to show the Bookmarks and mention that there are no bookmarks just to indicate to the user that this functionality exists and this is where new Bookmarks will appear

@gpeuc
Copy link
Contributor Author

gpeuc commented Jan 16, 2024

@hitesh-parmar Ah sure, we removed it to simplify development, but if we really want to do this, we could have some placeholder message telling people what's happening here. Can we develop that? Who has a bit of time to do it? I can easily design it, not a problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-priority:medium Medium Priority Bug type:ux-design UX design needed
Projects
None yet
Development

No branches or pull requests

3 participants