You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
If there are no Bookmarks saved, then we should remove the Bookmarks label. It's pointless to have it, since it labels null content. If
there are some Bookmarks and last one is removed, then of course, we remove the label as well.
The construction of Bookmarks H3 is wrong, and it should follow how H3 of "Last Visited" is constructed. There should be a span around text, so we can manipulate where the text is, and not have a space in front of the word Bookmark to space it away from the icon. Just copy the Last Visited construction and change the icon, no need to reinvent the wheel here.
The star is too high, needs to go down 1-2px so it's better aligned with the text. Most likely when last point is implemented then this one will automatically happen.
We need more space above Bookmarks label, as at the moment it is closer to the top element (Last Visited line item) than to the actual bookmark block.
It should have margin-top:30px altogether, so it is moved down. At the moment it has 15 top and 15 bottom, so let's just double the top one.
The text was updated successfully, but these errors were encountered:
If there are no Bookmarks saved, then we should remove the Bookmarks label. It's pointless to have it, since it labels null content. If
there are some Bookmarks and last one is removed, then of course, we remove the label as well.
Hi @gpeuc, Regarding point 1, wouldn't it be better to show the Bookmarks and mention that there are no bookmarks just to indicate to the user that this functionality exists and this is where new Bookmarks will appear
@hitesh-parmar Ah sure, we removed it to simplify development, but if we really want to do this, we could have some placeholder message telling people what's happening here. Can we develop that? Who has a bit of time to do it? I can easily design it, not a problem.
Hello everyone, @oliversberzs @carwelsh @theStiggySpd
Just a quick round of polish
If there are no Bookmarks saved, then we should remove the Bookmarks label. It's pointless to have it, since it labels null content. If
there are some Bookmarks and last one is removed, then of course, we remove the label as well.
The construction of Bookmarks H3 is wrong, and it should follow how H3 of "Last Visited" is constructed. There should be a span around text, so we can manipulate where the text is, and not have a
space
in front of the word Bookmark to space it away from the icon. Just copy the Last Visited construction and change the icon, no need to reinvent the wheel here.The star is too high, needs to go down 1-2px so it's better aligned with the text. Most likely when last point is implemented then this one will automatically happen.
We need more space above Bookmarks label, as at the moment it is closer to the top element (Last Visited line item) than to the actual bookmark block.
It should have
margin-top:30px
altogether, so it is moved down. At the moment it has 15 top and 15 bottom, so let's just double the top one.The text was updated successfully, but these errors were encountered: