Skip to content

Commit 2b5b596

Browse files
committed
Added data format version 8 description
- Added a description for data format version 8 and its changes - Increased timeout on error tests for FIXED types to reduce sporadic timeout failures
1 parent dd2a7b6 commit 2b5b596

File tree

2 files changed

+7
-0
lines changed

2 files changed

+7
-0
lines changed

lib/protocol/part/ConnectOptions.js

+1
Original file line numberDiff line numberDiff line change
@@ -121,6 +121,7 @@ function ConnectOptions() {
121121
// * `5` Support for ST_GEOMETRY and ST_POINT
122122
// * `6` Specifies to send the data type BINTEXT to the client
123123
// * `7` Support for BOOLEAN
124+
// * `8` Support for FIXED8/12/16
124125
// TODO: Once implementation and testing for data format version 4 are
125126
// complete, replace dataFormatVersion and dataFormatVersion2 with the
126127
// commented-out lines.

test/acceptance/db.DataType.js

+6
Original file line numberDiff line numberDiff line change
@@ -828,6 +828,8 @@ describe('db', function () {
828828
});
829829

830830
it('should raise input type error', function (done) {
831+
// Overflow validations are done one at a time, and some are done on the server, so this test can take longer
832+
this.timeout(3000);
831833
var invalidTestData = [
832834
// Overflows 15 digit precision with 5 decimal places
833835
{value: '10000000000', errMessage: 'numeric overflow: Failed in "A" column with the value 10000000000.00000'},
@@ -862,6 +864,8 @@ describe('db', function () {
862864
});
863865

864866
it('should raise input type error', function (done) {
867+
// Same as before, some overflow validations are on the server, so this test can take longer
868+
this.timeout(3000);
865869
var invalidTestData = [
866870
// Overflows 23 digit precision with 5 decimal places
867871
{value: '1000000000000000000', errMessage: 'numeric overflow: Failed in "A" column with the value 1000000000000000000.00000'},
@@ -899,6 +903,8 @@ describe('db', function () {
899903
});
900904

901905
it('should raise input type error', function (done) {
906+
// Same as before, some overflow validations are on the server, so this test can take longer
907+
this.timeout(3000);
902908
var invalidTestData = [
903909
// Overflows 35 digit precision with 5 decimal places
904910
{

0 commit comments

Comments
 (0)