Skip to content

Commit 1f98f07

Browse files
authored
feat: Add stable Ids in AddFragment and ControllerExtension forms (#2816)
* feat: add stable ids * refactor: format xml * chore: add changeset * chore: format file
1 parent 5efd9d2 commit 1f98f07

File tree

3 files changed

+26
-6
lines changed

3 files changed

+26
-6
lines changed

.changeset/rude-dragons-speak.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
---
2+
'@sap-ux-private/preview-middleware-client': patch
3+
'@sap-ux/preview-middleware': patch
4+
---
5+
6+
Add stable ids in AddFragment and ControllerExtension forms

packages/preview-middleware-client/src/adp/ui/AddFragment.fragment.xml

Lines changed: 19 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,11 @@
11
<Dialog id="addNewFragmentDialog"
22
xmlns="sap.m"
33
xmlns:core="sap.ui.core"
4+
xmlns:l="sap.ui.layout"
45
xmlns:f="sap.ui.layout.form"
56
title="{/title}"
67
contentWidth="500px"
8+
initialFocus="aggregationName"
79
class="sapUiRTABorder">
810
<content>
911
<f:SimpleForm id="addNewFragmentDialog_Form"
@@ -13,9 +15,14 @@
1315
singleContainerFullSize="false">
1416
<f:content>
1517
<Label visible="{/completeView}" text="{i18n>ADP_ADD_FRAGMENT_DIALOG_CONTROL_TYPE_LABEL}" />
16-
<Text visible="{/completeView}" text="{/selectedControlName}" />
18+
<Input
19+
id="controlType"
20+
visible="{/completeView}"
21+
value="{/selectedControlName}"
22+
editable="false" />
1723
<Label visible="{/completeView}" text="{i18n>ADP_ADD_FRAGMENT_DIALOG_AGGREGATION_LABEL}" />
1824
<Select
25+
id="aggregationName"
1926
visible="{/completeView}"
2027
change="onAggregationChanged"
2128
selectedKey="{/selectedAggregation/key}"
@@ -26,8 +33,8 @@
2633
<core:Item key="{key}" text="{value}" />
2734
</Select>
2835
<Label text="{i18n>ADP_ADD_FRAGMENT_DIALOG_INDEX_LABEL}" />
29-
<HBox alignItems="Center">
3036
<Select
37+
id="aggregationIndex"
3138
enabled="{/indexHandlingFlag}"
3239
selectedKey="{path: '/selectedIndex', type: 'sap.ui.model.type.Integer'}"
3340
items="{
@@ -37,14 +44,20 @@
3744
<core:Item key="{key}" text="{value}" />
3845
</Select>
3946
<core:Icon
47+
id="aggregationIndexInfoIcon"
4048
useIconTooltip="false"
4149
visible="{/specialIndexHandlingIcon}"
4250
src="sap-icon://message-information"
43-
class= "sapUiTinyMarginBegin"
44-
tooltip="{/iconTooltip}" />
45-
</HBox>
46-
<Label text="{i18n>ADP_ADD_FRAGMENT_DIALOG_FRAGMENT_NAME_LABEL}" />
51+
width="1rem"
52+
height="2rem"
53+
tooltip="{/iconTooltip}">
54+
<core:layoutData>
55+
<l:GridData span="S6" />
56+
</core:layoutData>
57+
</core:Icon>
58+
<Label text="{i18n>ADP_ADD_FRAGMENT_DIALOG_FRAGMENT_NAME_LABEL}" required="true" />
4759
<Input
60+
id="fragmentName"
4861
description=".fragment.xml"
4962
value="{/newFragmentName}"
5063
liveChange="onFragmentNameInputChange">

packages/preview-middleware-client/src/adp/ui/ControllerExtension.fragment.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@
1515
<f:content>
1616
<Label text="Controller Name" />
1717
<Input
18+
id="controllerName"
1819
description=".js"
1920
value="{/newControllerName}"
2021
liveChange="onControllerNameInputChange">

0 commit comments

Comments
 (0)