Merge remote-tracking branch 'origin/eslint9' into eslint9_merge_fiori_custom_into_fiori_tools_plugin

* origin/eslint9: (52 commits)
  chore: apply latest changesets
  update building block svg (#3826)
  chore: apply latest changesets
  feat(create): auto generate readme on build (#3760)
  chore: apply latest changesets
  Resolve Transport Request Checks for Download Quick Fiori App Deploy (#3819)
  test: v4 project builder (#3682)
  chore: apply latest changesets
  fix: bump specVersion to v4.0 (#3744)
  chore: apply latest changesets
  test: Integration test for fiori MCP using promptfoo (#3705)
  chore: apply latest changesets
  fix: move message to store creds prompt, tests, changeset (#3820)
  chore: apply latest changesets
  fix: bump fallback versions (#3813)
  chore: apply latest changesets
  chore - upgrade ui5 devDeps (#3771)
  correct publisher to SAPOSS (#3817)
  chore: apply latest changesets
  fix: cloud system render logic, message wording, test connection logging (#3811)
  ...

Author: devinea

.github/workflows/lint.yml

@@ -13,15 +13,16 @@ jobs:
   run-linters:
     strategy:
       matrix:
-          os: [ubuntu-latest]
-          node-version: [20.x]
+        os: [ubuntu-latest]
+        node-version: [20.x]
     runs-on: ${{ matrix.os }}
 
     steps:
       - name: Checkout code repository
         uses: actions/checkout@v4
         with:
-            ref: ${{ github.event.pull_request.head.ref }}            
+          repository: ${{ github.event.pull_request.head.repo.full_name }}
+          ref: ${{ github.event.pull_request.head.ref }}
       - name: Setup pnpm
         uses: pnpm/action-setup@v4
         with:
@@ -30,16 +31,16 @@ jobs:
       - name: Cache pnpm modules
         uses: actions/cache@v4
         env:
-            cache-name: cache-pnpm-modules
+          cache-name: cache-pnpm-modules
         with:
-            path: ~/.pnpm-store
-            key: ${{ matrix.os }}-build-${{ env.cache-name }}-${{ matrix.node-version }}-${{ hashFiles('**/pnpm-lock.yaml') }}
-            restore-keys: |
-                ${{ matrix.os }}-build-${{ env.cache-name }}-${{ matrix.node-version }}-
+          path: ~/.pnpm-store
+          key: ${{ matrix.os }}-build-${{ env.cache-name }}-${{ matrix.node-version }}-${{ hashFiles('**/pnpm-lock.yaml') }}
+          restore-keys: |
+            ${{ matrix.os }}-build-${{ env.cache-name }}-${{ matrix.node-version }}-
       - name: Use Node.js ${{ matrix.node-version }}
         uses: actions/setup-node@v4
         with:
-            node-version: ${{ matrix.node-version }}
+          node-version: ${{ matrix.node-version }}
       - name: Install pnpm modules
         run: pnpm install --frozen-lockfile
       - name: Run build
@@ -52,8 +53,18 @@ jobs:
           NX_CLOUD_ACCESS_TOKEN: ${{ secrets.NX_CLOUD_ACCESS_TOKEN }}
       - name: Commit lint fixes if any
         run: |
-                git config --global user.name github-actions[bot]
-                git config --global user.email github-actions[bot]@users.noreply.github.com
-                git add pnpm-lock.yaml
-                git commit -m "Linting auto fix commit" -a --no-verify || true
-                git push  || true
+          git config --global user.name github-actions[bot]
+          git config --global user.email github-actions[bot]@users.noreply.github.com
+          git add pnpm-lock.yaml
+          if git commit -m "Linting auto fix commit" -a --no-verify; then
+            CHANGED_FILES=$(git diff-tree --no-commit-id --name-only -r HEAD)
+            if ! git push; then
+              echo "::error::Failed to push lint fixes to remote repository. The commit was created locally but could not be pushed."
+              echo "::error::Files that could not be committed: $CHANGED_FILES"
+              echo "Fix the eslint issues locally and push the changes."
+              exit 1
+            fi
+            echo "Lint fixes committed and pushed successfully"
+          else
+            echo "No lint fixes needed"
+          fi

.github/workflows/pipeline.yml

@@ -59,15 +59,6 @@ jobs:
             - name: Validate changeset files if found
               if: steps.check_changeset_files.outputs.files_exists == 'true'
               run: pnpm changeset status
-            - name: Package SAP Systems VSCode extension
-              if: steps.check_changeset_files.outputs.files_exists == 'true' && matrix.os == 'ubuntu-latest' && matrix.node-version == '20.x'
-              run: |
-                  if grep -R "sap-ux-sap-systems-ext" .changeset/*.md >/dev/null 2>&1; then
-                    echo "sap-systems-ext referenced in changeset. Packaging extension..."
-                    pnpm --filter sap-ux-sap-systems-ext ide-ext:package
-                  else
-                    echo "sap-systems-ext not referenced in changeset. Skipping packaging."
-                  fi
             - name: Cache playwright browsers
               id: cache-playwright-browsers
               uses: actions/cache@v4
@@ -196,12 +187,17 @@ jobs:
                   node-version: 20.x
             - name: Install pnpm modules
               run: pnpm install --frozen-lockfile
-            - name: Replace placeholder with instrumentation key
+            - name: Set instrumentation key in fiori-mcp-server
+              uses: jacobtomlinson/gha-find-replace@v3
+              with:
+                  include: packages/fiori-mcp-server/src/telemetry/index.ts
+                  find: 'ApplicationInsightsInstrumentationKeyPLACEH0LDER'
+                  replace: ${{ secrets.INSTRUMENTATION_KEY }}
+                  regex: false
+            - name: Set instrumentation key in sap-systems-ext
               uses: jacobtomlinson/gha-find-replace@v3
               with:
-                  include: |
-                      packages/fiori-mcp-server/src/telemetry/index.ts
-                      packages/sap-systems-ext/src/utils/telemetryHelper.ts
+                  include: packages/sap-systems-ext/src/utils/telemetryHelper.ts
                   find: 'ApplicationInsightsInstrumentationKeyPLACEH0LDER'
                   replace: ${{ secrets.INSTRUMENTATION_KEY }}
                   regex: false
@@ -216,17 +212,42 @@ jobs:
                   publish: pnpm ci:publish
               env:
                   GITHUB_TOKEN: ${{ secrets.ACCESS_PAT }}
-            - name: Create GitHub Release (sap-systems-ext)
-              if: env.SAP_SYSTEMS_EXT_CHANGED == 'true'
+            - name: Detect extension publication
+              if: steps.changesetPublish.outputs.published == 'true'
+              run: |
+                  PUBLISHED=$(echo '${{ steps.changesetPublish.outputs.publishedPackages }}' | jq -r '.[].name')
+                  # Extract the first package name matching sap-ux-*-ext
+                  EXT_PKG=$(echo "$PUBLISHED" | grep -E '^sap-ux-.*-ext$' | head -n 1 || true)
+
+                  if [ -n "$EXT_PKG" ]; then
+                    echo "EXTENSION_UPDATED=true" >> $GITHUB_ENV
+                    echo "EXT_PKG=$EXT_PKG" >> $GITHUB_ENV
+
+                    # Strip 'sap-ux-' prefix to derive directory name
+                    EXT_DIR_NAME=$(echo "$EXT_PKG" | sed 's/^sap-ux-//')
+                    echo "EXT_DIR=packages/${EXT_DIR_NAME}" >> $GITHUB_ENV
+                  else
+                    echo "EXTENSION_UPDATED=false" >> $GITHUB_ENV
+                  fi
+            - name: Read extension version
+              if: env.EXTENSION_UPDATED == 'true'
+              run: |
+                  EXT_VERSION=$(jq -r '.version' "${{ env.EXT_DIR }}/package.json")
+                  echo "EXT_VERSION=$EXT_VERSION" >> $GITHUB_ENV
+            - name: Package VSCode extension
+              if: env.EXTENSION_UPDATED == 'true'
+              run: pnpm --filter ${{ env.EXT_PKG }} ide-ext:package
+            - name: Create GitHub Release (extension)
+              if: env.EXTENSION_UPDATED == 'true'
               uses: softprops/action-gh-release@v1
               with:
-                  tag_name: sap-systems-ext@${{ env.EXT_VERSION }}
-                  name: sap-systems-ext v${{ env.EXT_VERSION }}
-                  body: 'VSCode SAP Systems extension v${{ env.EXT_VERSION }} release.'
-                  draft: false
+                  tag_name: ${{ env.EXT_PKG }}@${{ env.EXT_VERSION }}
+                  name: ${{ env.EXT_PKG }} v${{ env.EXT_VERSION }}
+                  body: 'Extension release: ${{ env.EXT_PKG }} v${{ env.EXT_VERSION }}'
+                  draft: true
                   prerelease: false
                   generate_release_notes: true
-                  files: packages/sap-systems-ext/*.vsix
+                  files: ${{ env.EXT_DIR }}/*.vsix
                   fail_on_unmatched_files: true
               env:
                   GITHUB_TOKEN: ${{ secrets.ACCESS_PAT }}
@@ -240,9 +261,10 @@ jobs:
                   echo "$(echo '${{ steps.changesetPublish.outputs.publishedPackages }}' | jq --raw-output 'map("*" + .name + "*" + " - " + "<https://www.npmjs.com/package/" + .name + "|" + .version + ">") | join("\\n")')" >> $GITHUB_ENV
                   echo "$EOF" >> $GITHUB_ENV
             - name: Prepare Slack notification message (extension release only)
-              if: steps.changesetPublish.outputs.published != 'true' && env.SAP_SYSTEMS_EXT_CHANGED == 'true'
+              if: env.EXTENSION_UPDATED == 'true'
               run: |
-                  echo "EXT_RELEASE_MESSAGE=:package: VSCode SAP Systems extension v${{ env.EXT_VERSION }} released (private package)." >> $GITHUB_ENV
+                  RELEASE_URL="https://github.com/${{ github.repository }}/releases/tag/${{ env.EXT_PKG }}@${{ env.EXT_VERSION }}"
+                  echo "EXT_RELEASE_MESSAGE=:package: Extension *${{ env.EXT_PKG }}* v${{ env.EXT_VERSION }} released - <${RELEASE_URL}|View on GitHub>" >> $GITHUB_ENV
             - name: Send Slack notification (published packages)
               if: steps.changesetPublish.outputs.published == 'true'
               uses: slackapi/[email protected]
@@ -252,7 +274,7 @@ jobs:
               env:
                   SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_URL }}
             - name: Send Slack notification (extension release)
-              if: steps.changesetPublish.outputs.published != 'true' && env.SAP_SYSTEMS_EXT_CHANGED == 'true'
+              if: env.EXTENSION_UPDATED == 'true'
               uses: slackapi/[email protected]
               with:
                   payload: |

examples/fe-fpm-cli/CHANGELOG.md

@@ -1,5 +1,18 @@
 # @sap-ux/fe-fpm-cli
 
+## 0.1.55
+
+### Patch Changes
+
+-   Updated dependencies [cfe9c13]
+    -   @sap-ux/fe-fpm-writer@0.39.17
+
+## 0.1.54
+
+### Patch Changes
+
+-   @sap-ux/fe-fpm-writer@0.39.16
+
 ## 0.1.53
 
 ### Patch Changes

examples/fe-fpm-cli/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@sap-ux/fe-fpm-cli",
-    "version": "0.1.53",
+    "version": "0.1.55",
     "description": "A simple CLI to prompt required information to create a building block using the fe-fpm-writer module's prompt and generate functions.",
     "license": "Apache-2.0",
     "private": true,

examples/odata-cli/CHANGELOG.md

@@ -1,5 +1,14 @@
 # @sap-ux/odata-cli
 
+## 0.17.20
+
+### Patch Changes
+
+-   Updated dependencies [cfe9c13]
+    -   @sap-ux/btp-utils@1.1.5
+    -   @sap-ux/logger@0.7.1
+    -   @sap-ux/axios-extension@1.24.2
+
 ## 0.17.19
 
 ### Patch Changes

examples/odata-cli/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@sap-ux/odata-cli",
-    "version": "0.17.19",
+    "version": "0.17.20",
     "description": "Simple example CLI uing the @sap-ux/axios-extension module to fetch metadata and annotations from an SAP system.",
     "license": "Apache-2.0",
     "private": true,

examples/simple-generator/CHANGELOG.md

@@ -1,5 +1,38 @@
 # @sap-ux/generator-simple-fe
 
+## 1.1.109
+
+### Patch Changes
+
+-   Updated dependencies [aa2c7df]
+    -   @sap-ux/fiori-freestyle-writer@2.5.0
+    -   @sap-ux/fiori-elements-writer@2.8.0
+
+## 1.1.108
+
+### Patch Changes
+
+-   @sap-ux/fiori-elements-writer@2.7.37
+-   @sap-ux/fiori-freestyle-writer@2.4.61
+
+## 1.1.107
+
+### Patch Changes
+
+-   Updated dependencies [cfe9c13]
+    -   @sap-ux/fiori-freestyle-writer@2.4.60
+    -   @sap-ux/fiori-elements-writer@2.7.36
+    -   @sap-ux/system-access@0.6.28
+    -   @sap-ux/btp-utils@1.1.5
+    -   @sap-ux/logger@0.7.1
+    -   @sap-ux/axios-extension@1.24.2
+
+## 1.1.106
+
+### Patch Changes
+
+-   @sap-ux/fiori-elements-writer@2.7.35
+
 ## 1.1.105
 
 ### Patch Changes

examples/simple-generator/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@sap-ux/generator-simple-fe",
-    "version": "1.1.105",
+    "version": "1.1.109",
     "description": "Simple example of a yeoman generator for Fiori elements.",
     "license": "Apache-2.0",
     "private": true,

examples/ui-prompting-examples/CHANGELOG.md

@@ -1,5 +1,21 @@
 # @sap-ux-private/ui-prompting-examples
 
+## 0.4.7
+
+### Patch Changes
+
+-   Updated dependencies [afb4be5]
+    -   @sap-ux/ui-components@1.26.15
+    -   @sap-ux/ui-prompting@0.5.6
+
+## 0.4.6
+
+### Patch Changes
+
+-   Updated dependencies [cfe9c13]
+    -   @sap-ux/ui-components@1.26.14
+    -   @sap-ux/ui-prompting@0.5.5
+
 ## 0.4.5
 
 ### Patch Changes

examples/ui-prompting-examples/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@sap-ux-private/ui-prompting-examples",
-    "version": "0.4.5",
+    "version": "0.4.7",
     "description": "This project contains UI storybook stories with exampleS with prompt ui and FPM based building blocks.",
     "license": "Apache-2.0",
     "private": true,