Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG - Reuse component are not detected correctly in Adaptation Project #3045

Open
3 tasks
mmilko01 opened this issue Mar 24, 2025 · 0 comments
Open
3 tasks

Comments

@mmilko01
Copy link
Contributor

Description

  • Current logic for detecting reuse component in applications is giving false positive result. It flags UI components as reuse components that shouldn't be flagged
  • Disabling of the context menu items for Add: Fragment and Extend with Controller should be done on control level and not view level
  • Current pop-up warning the user that reuse components are detected should be removed

Steps to Reproduce (Warning popup)

Steps to reproduce the behavior:
1 Create and Adaptation Project for base application that contains reuse components in Cloud
2. Open the Adaptation Editor
3. See the pop-up for reuse component waring after loading

Expected results

Warning pop-up is not shown

Actual results

Pop-up appears in Adaptation Editor

Steps to Reproduce (Detection logic)

Steps to reproduce the behavior:
1 Create and Adaptation Project for base application that contains reuse components in Cloud
2. Open the Adaptation Editor
3. Right click on a view with a reuse component
4. See that context menu items for Add: Fragment and Extend with Controller are not disabled

Expected results

  • Both context menu items should be disabled when clicking on a control inside the reuse component
  • Context menu items should be available when right clicking on a control outside of the reuse component in the same view

Actual results

Context menu items are never disabled

Version/Components/Environment

Add any other context about the problem here
OS:

  • Mac OS
  • Windows
  • Other

Root Cause Analysis

Problem

{describe the problem}

Fix

{describe the fix}

Why was it missed

{Some explanation why this issue might have been missed during normal development/testing cycle}

How can we avoid this

{if we don’t want to see this type of issues anymore what we should do to prevent}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant