feat: Store view name as part of additional info in fragment body #3696
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 225b206 The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
nikmace
added
feature
nikmace
previously approved these changes
Oct 7, 2025
voicis
reviewed
Oct 13, 2025
Comment on lines
31
to
42
| if (templateName || (controlType && targetAggregation && viewName)) { | ||
| const result: AddXMLAdditionalInfo = {}; | ||
| if (templateName) { | ||
| result.templateName = templateName; | ||
| } | ||
| if (controlType && targetAggregation && viewName) { | ||
| result.targetAggregation = targetAggregation; | ||
| result.controlType = controlType; | ||
| result.viewName = viewName; | ||
| } | ||
| return result; | ||
| } |
There was a problem hiding this comment.
This doesn't seem to scale well. Next time we need to add something else we'll need to add another set of conditions which are repeated in two places. Maybe we can just check if there are any keys set before we return?
return Object.keys(result).length > 0 ? result : undefined;
Comment on lines
97
to
99
| if (isA('sap.ui.core.mvc.View', control)) { | ||
| return control as View; | ||
| } |
There was a problem hiding this comment.
Suggested change
| if (isA('sap.ui.core.mvc.View', control)) { | |
| return control as View; | |
| } | |
| if (isA<View>('sap.ui.core.mvc.View', control)) { | |
| return control; | |
| } |
…b.com/SAP/open-ux-tools into feat/3479/sotre-view-name-in-fragment
IvoSG
force-pushed
the
feat/3479/sotre-view-name-in-fragment
branch
from
017546c to
82ccbb4
Compare
IvoSG
force-pushed
the
feat/3479/sotre-view-name-in-fragment
branch
from
82ccbb4 to
225b206
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feat for #3479.