From 82f49a3b3dae98572f312e53b97ea8cd3bd59595 Mon Sep 17 00:00:00 2001 From: John Long Date: Mon, 24 Nov 2025 15:50:52 +0000 Subject: [PATCH 1/4] fix: alignment fallback ui5 versions --- packages/ui5-info/src/ui5-version-fallback.ts | 2 +- .../ui5-version-info.test.ts.snap | 19 ------------------- packages/ui5-info/test/commands.test.ts | 9 ++------- 3 files changed, 3 insertions(+), 27 deletions(-) diff --git a/packages/ui5-info/src/ui5-version-fallback.ts b/packages/ui5-info/src/ui5-version-fallback.ts index c887808885f..0c8775b5237 100644 --- a/packages/ui5-info/src/ui5-version-fallback.ts +++ b/packages/ui5-info/src/ui5-version-fallback.ts @@ -16,7 +16,7 @@ export const ui5VersionFallbacks = [ }, { version: '1.141.*', - support: supportState.maintenance + support: supportState.outOfMaintenance }, { version: '1.140.*', diff --git a/packages/ui5-info/test/__snapshots__/ui5-version-info.test.ts.snap b/packages/ui5-info/test/__snapshots__/ui5-version-info.test.ts.snap index db55d8ab843..07839203032 100644 --- a/packages/ui5-info/test/__snapshots__/ui5-version-info.test.ts.snap +++ b/packages/ui5-info/test/__snapshots__/ui5-version-info.test.ts.snap @@ -4995,10 +4995,6 @@ exports[`getUI5Versions: Handle error cases while getting UI5 versions: UI5 ver "maintained": true, "version": "1.142.0", }, - { - "maintained": true, - "version": "1.141.0", - }, { "maintained": true, "version": "1.139.0", @@ -5035,9 +5031,6 @@ exports[`getUI5Versions: Handle error cases while getting UI5 versions: UI5 ver { "version": "1.142.0", }, - { - "version": "1.141.0", - }, { "version": "1.139.0", }, @@ -5067,9 +5060,6 @@ exports[`getUI5Versions: Handle error cases while getting UI5 versions: UI5 ver { "version": "1.142.0", }, - { - "version": "1.141.0", - }, { "version": "1.139.0", }, @@ -5099,9 +5089,6 @@ exports[`getUI5Versions: Handle error cases while getting UI5 versions: UI5 ver { "version": "1.142.0", }, - { - "version": "1.141.0", - }, { "version": "1.139.0", }, @@ -5131,9 +5118,6 @@ exports[`getUI5Versions: Handle fatal cases while getting UI5 versions: UI5 ver { "version": "1.142.0", }, - { - "version": "1.141.0", - }, { "version": "1.139.0", }, @@ -5163,9 +5147,6 @@ exports[`getUI5Versions: Handle fatal cases while getting UI5 versions: UI5 ver { "version": "1.142.0", }, - { - "version": "1.141.0", - }, { "version": "1.139.0", }, diff --git a/packages/ui5-info/test/commands.test.ts b/packages/ui5-info/test/commands.test.ts index 0f712b419cb..d59e27a4db7 100644 --- a/packages/ui5-info/test/commands.test.ts +++ b/packages/ui5-info/test/commands.test.ts @@ -105,15 +105,12 @@ describe('Retrieve NPM UI5 mocking spawn process', () => { onlyNpmVersion: true }); // expect defaults expect(retrievedUI5Versions[0]).toEqual({ version: '1.142.0' }); - expect(retrievedUI5Versions.length).toEqual(9); + expect(retrievedUI5Versions.length).toEqual(8); expect(retrievedUI5Versions).toMatchInlineSnapshot(` [ { "version": "1.142.0", }, - { - "version": "1.141.0", - }, { "version": "1.139.0", }, @@ -244,8 +241,6 @@ describe('Test commands internals', () => { it('Execute with error code 1', async () => { mockedSpawn.setDefault(mockedSpawn.simple(1, '', 'stack trace')); const npmCmd = os.platform() === 'win32' ? 'npm.cmd' : 'npm'; - await expect(executeNpmUI5VersionsCmd()).rejects.toMatchInlineSnapshot( - `[Error: Command failed, \`${npmCmd} show @sapui5/distribution-metadata versions --no-color\`, stack trace]` - ); + await expect(executeNpmUI5VersionsCmd()).rejects.toMatchInlineSnapshot(`[Error: Command failed, \``); }); }); From 0b49a161031004a9bcb0c7c09ed6574958c3086b Mon Sep 17 00:00:00 2001 From: John Long Date: Mon, 24 Nov 2025 15:52:14 +0000 Subject: [PATCH 2/4] fix: add changeset --- .changeset/crisp-adults-sort.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/crisp-adults-sort.md diff --git a/.changeset/crisp-adults-sort.md b/.changeset/crisp-adults-sort.md new file mode 100644 index 00000000000..89585e439dd --- /dev/null +++ b/.changeset/crisp-adults-sort.md @@ -0,0 +1,5 @@ +--- +'@sap-ux/ui5-info': patch +--- + +Alignment of UI5 fallback versions From b5a371b90734f97bb7262430c5417fbc33d357b8 Mon Sep 17 00:00:00 2001 From: John Long Date: Mon, 24 Nov 2025 16:13:25 +0000 Subject: [PATCH 3/4] fix: align changes --- packages/ui5-info/test/commands.test.ts | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/packages/ui5-info/test/commands.test.ts b/packages/ui5-info/test/commands.test.ts index d59e27a4db7..7598c987357 100644 --- a/packages/ui5-info/test/commands.test.ts +++ b/packages/ui5-info/test/commands.test.ts @@ -241,6 +241,8 @@ describe('Test commands internals', () => { it('Execute with error code 1', async () => { mockedSpawn.setDefault(mockedSpawn.simple(1, '', 'stack trace')); const npmCmd = os.platform() === 'win32' ? 'npm.cmd' : 'npm'; - await expect(executeNpmUI5VersionsCmd()).rejects.toMatchInlineSnapshot(`[Error: Command failed, \``); + await expect(executeNpmUI5VersionsCmd()).rejects.toMatchInlineSnapshot( + `[Error: Command failed, \`${npmCmd} show @sapui5/distribution-metadata versions --no-color\`, stack trace]` + ); }); }); From c10953dbb8757179fb89c7f6e634427f1b495366 Mon Sep 17 00:00:00 2001 From: John Long Date: Mon, 24 Nov 2025 17:26:04 +0000 Subject: [PATCH 4/4] fix: align date --- packages/ui5-info/src/ui5-version-fallback.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/ui5-info/src/ui5-version-fallback.ts b/packages/ui5-info/src/ui5-version-fallback.ts index 0c8775b5237..31f0b690311 100644 --- a/packages/ui5-info/src/ui5-version-fallback.ts +++ b/packages/ui5-info/src/ui5-version-fallback.ts @@ -8,7 +8,7 @@ export const supportState = { skipped: 'Skipped' } as const; -// Updated Nov-06-2025 from https://ui5.sap.com/versionoverview.json +// Updated Nov-24-2025 from https://ui5.sap.com/versionoverview.json export const ui5VersionFallbacks = [ { version: '1.142.*',