Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing autofix for methods related to jQuery.sap.measure.* (Measure Utils) #555

Open
16 tasks
flovogt opened this issue Feb 20, 2025 · 1 comment
Open
16 tasks
Labels
autofix An issue related to the autofix capabilities enhancement New feature or request

Comments

@flovogt
Copy link
Member

flovogt commented Feb 20, 2025

Missing autofix for methods related to jQuery.sap.measure.* (Measure Utils)

Methods related to jQuery.sap.measure.* (Measure Utils) are deprecated. Therefore an autofix should be offered by UI5 linter.

Deprecated APIs:

  • jQuery.sap.measure.start
  • jQuery.sap.measure.add
  • jQuery.sap.measure.end
  • jQuery.sap.measure.average
  • jQuery.sap.measure.clear
  • jQuery.sap.measure.filterMeasurements
  • jQuery.sap.measure.getAllMeasurements
  • jQuery.sap.measure.getMeasurement
  • jQuery.sap.measure.pause
  • jQuery.sap.measure.resume
  • jQuery.sap.measure.getActive
  • jQuery.sap.measure.setActive
  • jQuery.sap.measure.remove
  • jQuery.sap.measure.registerMethod
  • jQuery.sap.measure.unregisterMethod
  • jQuery.sap.measure.unregisterAllMethods

Deprecated Usage

var entryAfterStart = jQuery.sap.measure.start("measureA", "This is measure A", "categoryX");
var entryAfterAdd = jQuery.sap.measure.add("measureB", "This is measure B", 1335420000000, 1335420060000, 60000, 500);
var entryAfterEnd = jQuery.sap.measure.end("measureA");
var averageEntry = jQuery.sap.measure.average("measureA", "Average of measure A");
jQuery.sap.measure.clear();
var filteredEntries = jQuery.sap.measure.filterMeasurements((o) => {return o.categories.indexOf("categoryX") > -1 ? o : null; });
var allEntries = jQuery.sap.measure.getAllMeasurements(true);
var entry = jQuery.sap.measure.getMeasurement("measureB");
var pausedEntry = jQuery.sap.measure.pause("measureB");
var resumedEntry = jQuery.sap.measure.resume("measureB");
var isActive = jQuery.sap.measure.getActive();
var isStillActive = jQuery.sap.measure.setActive(true, ["categoryX", "categoryZ"]);
jQuery.sap.measure.remove("measureA");
var myFunctionObject = {myFunction: () => console.log("test")};
var isRegisterSuccessful = jQuery.sap.measure.registerMethod("measureC", myFunctionObject, "myFunction");
var isUnregisterSuccessful = jQuery.sap.measure.unregisterMethod("measureC", myFunctionObject, "myFunction");
jQuery.sap.measure.unregisterAllMethods();

Recommended Usage

sap.ui.define([
   "sap/ui/performance/Measurement"
  ], (Measurement) => {
  var entryAfterStart = Measurement.start("measureA", "This is measure A", "categoryX");
  var entryAfterAdd = Measurement.add("measureB", "This is measure B", 1335420000000, 1335420060000, 60000, 500);
  var entryAfterEnd = Measurement.end("measureA");
  var averageEntry = Measurement.average("measureA", "Average of measure A");
  Measurement.clear();
  var filteredEntries = Measurement.filterMeasurements((o) => {return o.categories.indexOf("categoryX") > -1 ? o : null; });
  var allEntries = Measurement.getAllMeasurements(true);
  var entry = Measurement.getMeasurement("measureB");
  var pausedEntry = Measurement.pause("measureB");
  var resumedEntry = Measurement.resume("measureB");
  var isActive = Measurement.getActive();
  var isStillActive = Measurement.setActive(true, ["categoryX", "categoryZ"]);
  Measurement.remove("measureA");
  var myFunctionObject = {myFunction: () => console.log("test")};
  var isRegisterSuccessful = Measurement.registerMethod("measureC", myFunctionObject, "myFunction");
  var isUnregisterSuccessful = Measurement.unregisterMethod("measureC", myFunctionObject, "myFunction");
  Measurement.unregisterAllMethods();
});
@flovogt flovogt added autofix An issue related to the autofix capabilities enhancement New feature or request labels Feb 20, 2025
@flovogt
Copy link
Member Author

flovogt commented Feb 20, 2025

Will be implemented in CPOUI5FOUNDATION-990.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autofix An issue related to the autofix capabilities enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant