Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AnalyticalTable]: [RowSelector has no icon to click] #6948

Open
1 task done
DrMalchev opened this issue Feb 13, 2025 · 3 comments
Open
1 task done

[AnalyticalTable]: [RowSelector has no icon to click] #6948

DrMalchev opened this issue Feb 13, 2025 · 3 comments

Comments

@DrMalchev
Copy link

DrMalchev commented Feb 13, 2025

In AnalyticalTable selectionBehavior="RowSelector" and selectionMode="Single" there opens a space on the left of each row. Clicking on this space fires the onRowSelect event, but the space is empty. Being empty is not intuitive that there is a button functionality. Can you add an Icon property, or button to be visible for the user to click.

Describe the bug

Image

Isolated Example

No response

Reproduction steps

...

Expected Behaviour

No response

Screenshots or Videos

No response

UI5 Web Components for React Version

2.7.1

UI5 Web Components Version

2.7.1

Browser

Chrome

Operating System

No response

Additional Context

No response

Relevant log output

Organization

No response

Declaration

  • I’m not disclosing any internal or sensitive information.
@Lukas742
Copy link
Contributor

Lukas742 commented Feb 13, 2025

Hi @DrMalchev

please add descriptions of issues as text, as this way GitHub can index them for their search functionality.

Adding an icon in the single-selection cell is not covered by central design, so for this to be implemented this request would need to go through the Inner Source process and be synchronised with the SAP Central Design team first. Please raise a BLI to the central design team and include the ticket number here for reference.

That said, it's probably already possible adding an icon (or radio button?) there via a plugin hook. But since the hook most probably needs to use internal APIs, it could break with each update (although it's not very likely). If you still want to implement the hook, I can create an example for it which you can adjust to meet your design, just let me know :)

@DrMalchev
Copy link
Author

Hi @Lukas742 ,
thanks for the quick response. I added description.
I can add a custom cell that can accomodate buttons, but that is custom and I think that it should be available out of the box.

Do you have a link to open a ticket at SAP Central Design team?

@Lukas742
Copy link
Contributor

@DrMalchev I've sent you a Teams message internally :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 🆕 New
Development

No branches or pull requests

2 participants