Skip to content

Commit 5221626

Browse files
NakataCodes-todorova
authored andcommitted
fix(ui5-dynamic-page): validate aria-controls reference before rendering (#11033)
Problem: Invalid ARIA attributes were being generated when the referenced header element wasn't available with the exact ID. Solution: Remove _accAttributesForHeaderActions because the header and the (pin/unpin/expand/collapse) actions exist in separate shadow DOMs. Fixes: #10987
1 parent b32f194 commit 5221626

File tree

2 files changed

+0
-7
lines changed

2 files changed

+0
-7
lines changed

packages/fiori/src/DynamicPage.ts

-6
Original file line numberDiff line numberDiff line change
@@ -241,12 +241,6 @@ class DynamicPage extends UI5Element {
241241
return !this._headerSnapped;
242242
}
243243

244-
get _accAttributesForHeaderActions() {
245-
return {
246-
controls: `${this._id}-header` as Lowercase<string>,
247-
};
248-
}
249-
250244
get headerTabIndex() {
251245
return (this._headerSnapped || this.showHeaderInStickArea) ? -1 : 0;
252246
}

packages/fiori/src/DynamicPageTemplate.tsx

-1
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,6 @@ function headerActions(this: DynamicPage) {
5858
snapped={this.headerSnapped}
5959
pinned={this.headerPinned}
6060
hidePinButton={this.hidePinButton}
61-
accessibilityAttributes={this._accAttributesForHeaderActions}
6261
onui5-expand-button-click={this.onExpandClick}
6362
onui5-pin-button-click={this.onPinClick}
6463
onui5-expand-button-hover-in={this.onExpandHoverIn}

0 commit comments

Comments
 (0)