test(ui5-time-picker-clock): TimePickerClock cypress tests#11680
Merged
test(ui5-time-picker-clock): TimePickerClock cypress tests#11680
Conversation
nnaydenow
reviewed
Jun 10, 2025
nnaydenow
reviewed
Jun 12, 2025
| it("'disabled' property", () => { | ||
| cy.mount( | ||
| <> | ||
| <div style="display: inline-block; text-align: center; width: 18rem; height: 18rem; touch-action: none; margin: 2rem;"> |
Contributor
There was a problem hiding this comment.
could be extracted into function which is going to be used into JSX to render the component
| <div style="display: inline-block; text-align: center; width: 18rem; height: 18rem; touch-action: none; margin: 2rem;"> | ||
| <TimePickerClock id="myHours12" label="myHours12" itemMin={1} itemMax={12} displayStep={1} selectedValue={12} active></TimePickerClock> | ||
| </div> | ||
| <div style="display: inline-block; text-align: center; width: 18rem; height: 18rem; touch-action: none; margin: 2rem;"> |
Contributor
There was a problem hiding this comment.
use map with config object to render these time picker clocks
nnaydenow
approved these changes
Jun 12, 2025
nnaydenow
approved these changes
Jun 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cypress tests for TimePickerClock component