Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure tests for multi-staged builds (if necessary) #15

Open
evrardjp opened this issue May 4, 2021 · 1 comment
Open

Restructure tests for multi-staged builds (if necessary) #15

evrardjp opened this issue May 4, 2021 · 1 comment

Comments

@evrardjp
Copy link
Contributor

evrardjp commented May 4, 2021

Currently the tests are in the root folder. They are easily discoverable, but it's gonna be a mess if we do different kinds of testing.

I am suggesting here to create multiple folders based on test cases:

  • tests/single/test_<language>.py can take care of the simple builds, for those not doing multi-staged builds
  • tests/multistaged/test_<language>.py to test multi staged builds
  • tests/pack/test_<buildpack>.py to ensure paketo/buildpacks.io are working as expected with our base images.

For this, we will have to:

  • rewire tox to point to the right tests
  • refactor some tests: extract them from tests_ and split them into the right folders
  • Create multi staged containers in obs
  • Modify data structures in matryoshka_tester/data.py to add the newly built containers. If data.py become more convoluted, we might want to add convenience datastructures. We need to adapt existing tests to new structure.
@evrardjp evrardjp changed the title Restructure tests Restructure tests for multi-staged builds (if necessary) May 4, 2021
@evrardjp
Copy link
Contributor Author

This can stay open, even if we moved to multi-staged. We'll see if we need re-organisation of data later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant