Skip to content

Commit af8efd4

Browse files
mosofskyMichael Osofskyclaude
authored
Feature/publish abc clinical demand forecast 4.0.0 (#5671)
- Added abc-clinical-demand-forecast-4.0.0.json schema file - Updated catalog.json to include version 4.0.0 and set as default - Updated schema-validation.jsonc with validation configuration - Added positive test case for version 4.0.0 - Copied negative test cases from version 3.0.0 Key changes in version 4.0.0: - Added optional enrollmentStartOffset property in two object definitions (one for child-region defaults, one for actual-value-with-inherit). Type: integer or null. Minimum: 0. Default: 0. Represents months from site activation until first enrollment (First Patient In lead time). Null means inherit from parent; the default-for-child-regions variant defaults to 0 if no ancestor sets a value. - The property is NOT in any required array, so existing 3.0.0 data validates against 4.0.0 unchanged. The major-version designation reflects that the new property meaningfully changes lead-time behavior for downstream consumers even though the schema permits omitting it. Testing: - Validated schema-specific: node ./cli.js check --schema-name=abc-clinical-demand-forecast-4.0.0.json (PASS) - Validated full test suite: node ./cli.js check (PASS, all 806 tested schemas) - Re-ran node ./cli.js check after rebasing onto current origin/master and after folding in pre-commit.ci auto-fix formatting: PASS, no errors or failures. Rebase note: this branch was rebased onto origin/master to resolve merge conflicts. The original 2.0.0 and 3.0.0 commits on this branch were dropped because those versions were already merged upstream via PR #5670. The pre-commit.ci auto-fix commit's formatting changes for the 4.0.0 schema (compact enum arrays, AUTO-GENERATED header comment) were folded into this commit so the rebased branch matches what the bot would otherwise re-push. Co-authored-by: Michael Osofsky <michael@abc-plan.com> Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
1 parent b5a375a commit af8efd4

5 files changed

Lines changed: 2164 additions & 2 deletions

File tree

src/api/json/catalog.json

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -221,11 +221,12 @@
221221
"name": "ABCClinicalDemandForecast",
222222
"description": "ABCClinicalDemandForecast defining the structure of clinical trial demand forecasting data in ABC-Plan",
223223
"fileMatch": ["abc-clinical-demand-forecast-*.json"],
224-
"url": "https://www.schemastore.org/abc-clinical-demand-forecast-3.0.0.json",
224+
"url": "https://www.schemastore.org/abc-clinical-demand-forecast-4.0.0.json",
225225
"versions": {
226226
"1.0.0": "https://www.schemastore.org/abc-clinical-demand-forecast-1.0.0.json",
227227
"2.0.0": "https://www.schemastore.org/abc-clinical-demand-forecast-2.0.0.json",
228-
"3.0.0": "https://www.schemastore.org/abc-clinical-demand-forecast-3.0.0.json"
228+
"3.0.0": "https://www.schemastore.org/abc-clinical-demand-forecast-3.0.0.json",
229+
"4.0.0": "https://www.schemastore.org/abc-clinical-demand-forecast-4.0.0.json"
229230
}
230231
},
231232
{
Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
1+
{
2+
"analytics": {
3+
"items": [],
4+
"layouts": [],
5+
"tabs": []
6+
},
7+
"clinicalDemandCalculatedForecast": null,
8+
"clinicalDemandForecastConfiguration": {},
9+
"planNotes": ""
10+
}

src/schema-validation.jsonc

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -454,6 +454,9 @@
454454
"abc-clinical-demand-forecast-3.0.0.json": {
455455
"unknownKeywords": ["abcHasValidKitItemReferences"]
456456
},
457+
"abc-clinical-demand-forecast-4.0.0.json": {
458+
"unknownKeywords": ["abcHasValidKitItemReferences"]
459+
},
457460
"abc-supply-plan-1.0.0.json": {
458461
"unknownFormat": ["abc-draft-js_RawDraftContentState"],
459462
"unknownKeywords": [

0 commit comments

Comments
 (0)